Skip to content

Display fallback message if not refund reason provided#5887

Merged
lkostrowski merged 1 commit intomainfrom
fix-e2e-refunds
Sep 23, 2025
Merged

Display fallback message if not refund reason provided#5887
lkostrowski merged 1 commit intomainfrom
fix-e2e-refunds

Conversation

@lkostrowski
Copy link
Member

In the new refund reasons feature instead of "manual refund" we display refund type and/or arbitrary refund reason.

In case of missing both of them (not provided by users), refunds table displays empty message.

This PR restores "manual refund" message as a fallback value. It also fixes failing e2e test that asserts this text on the screen

Copilot AI review requested due to automatic review settings September 22, 2025 07:39
@lkostrowski lkostrowski requested a review from a team as a code owner September 22, 2025 07:39
@lkostrowski lkostrowski added the run pw-e2e Run e2e (basic suite from PR automation) label Sep 22, 2025
@lkostrowski lkostrowski requested a review from kzuraw September 22, 2025 07:39
@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2025

⚠️ No Changeset found

Latest commit: 3fc981c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
saleor-dashboard-storybook Ignored Ignored Sep 22, 2025 7:39am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restores a fallback message for refunds that lack both refund reason type and refund reason note. When neither value is provided, the refund table will now display "manual refund" as a fallback instead of showing empty content.

  • Adds a fallback display message for refunds missing both reason type and reason note
  • Imports refund grid messages for the fallback text
  • Fixes a failing e2e test that expects this fallback text to be present

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.65%. Comparing base (9af22c3) to head (3fc981c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #5887     +/-   ##
=========================================
  Coverage   38.64%   38.65%             
=========================================
  Files        2742     2742             
  Lines       43228    43231      +3     
  Branches     9449     9803    +354     
=========================================
+ Hits        16707    16710      +3     
+ Misses      26491    25209   -1282     
- Partials       30     1312   +1282     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lkostrowski lkostrowski added the skip changeset Use if your changes doesn't need entry in changelog label Sep 22, 2025
@lkostrowski lkostrowski enabled auto-merge (squash) September 22, 2025 07:53
@lkostrowski lkostrowski merged commit f128856 into main Sep 23, 2025
35 of 45 checks passed
@lkostrowski lkostrowski deleted the fix-e2e-refunds branch September 23, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run pw-e2e Run e2e (basic suite from PR automation) skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants