Skip to content

Remove unused plugin list components and filters#5915

Merged
lkostrowski merged 2 commits intomainfrom
remove-dead-code-2
Oct 1, 2025
Merged

Remove unused plugin list components and filters#5915
lkostrowski merged 2 commits intomainfrom
remove-dead-code-2

Conversation

@lkostrowski
Copy link
Member

@lkostrowski lkostrowski commented Oct 1, 2025

Summary

This PR removes dead code related to the plugin list UI and filtering functionality:

  • Removed plugin list components: Deleted PluginsList, PluginsListPage, and related table components that are no longer used
  • Removed plugin filters: Cleaned up PluginList view with filtering logic, tests, and snapshots
  • Removed unused shared components: Deleted FilterBar and SearchBar components that were only used by plugins
  • Removed unused utilities: Cleaned up useChannelsSearchWithLoadMore hook, custom app fixtures, and utility functions
  • Updated exports: Changed pluginListPath and pluginPath from exported to internal constants in src/plugins/urls.ts:16 and src/plugins/urls.ts:43

🤖 Generated with Claude Code

@lkostrowski lkostrowski requested a review from a team as a code owner October 1, 2025 07:29
@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2025

⚠️ No Changeset found

Latest commit: 7c98c76

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
saleor-dashboard-storybook Ignored Ignored Oct 1, 2025 7:29am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unused plugin list components and filtering functionality from the dashboard, focusing on cleaning up dead code related to the plugin management UI.

  • Removes plugin list UI components including PluginsList, PluginsListPage, and related table components
  • Eliminates plugin filtering logic, tests, and associated utilities
  • Changes plugin URL helpers from exported to internal constants to prevent external usage

Reviewed Changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/utils/maps.ts Removes unused mapPagesToChoices function and related imports
src/plugins/views/PluginList/ Deletes entire directory containing filtering logic, sorting, and main PluginList component
src/plugins/urls.ts Changes pluginListPath and pluginPath from exported to internal constants
src/plugins/plugins-with-app-replacements.ts Removes deprecated function for identifying plugins with app replacements
src/plugins/components/PluginsListPage/ Removes plugin list page component and related filtering infrastructure
src/plugins/components/PluginsList/ Deletes plugin list table components and availability cells
src/misc.ts Removes unused findById utility function
src/icons/Miscellaneous.tsx Removes deprecated Material-UI icon component
src/hooks/useChannelsSearchWithLoadMore.ts Deletes unused hook for channel search with pagination
src/extensions/components/EmptyListState/EmptyInstalledList.tsx Removes empty state component
src/custom-apps/views/CustomAppCreate/ Deletes custom app creation view and messages
src/custom-apps/utils.tsx Removes unused buildEventsMap function
src/custom-apps/fixtures.ts Deletes test fixtures
src/components/SearchBar/ Removes entire SearchBar component directory
src/components/FilterBar/ Deletes FilterBar component and related functionality
src/apps/messages.ts Removes unused app activation/deactivation messages
locale/defaultMessages.json Cleans up unused translation keys

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lkostrowski lkostrowski added the skip changeset Use if your changes doesn't need entry in changelog label Oct 1, 2025
@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.35%. Comparing base (f832b9b) to head (7c98c76).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5915      +/-   ##
==========================================
+ Coverage   39.22%   39.35%   +0.13%     
==========================================
  Files        2671     2649      -22     
  Lines       42277    42024     -253     
  Branches     9543     9481      -62     
==========================================
- Hits        16582    16540      -42     
+ Misses      25668    25457     -211     
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lkostrowski lkostrowski merged commit a01d3ba into main Oct 1, 2025
29 of 35 checks passed
@lkostrowski lkostrowski deleted the remove-dead-code-2 branch October 1, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants