Skip to content

Remove dead code from custom apps#5917

Merged
lkostrowski merged 11 commits intomainfrom
remove-dead-code-4
Oct 1, 2025
Merged

Remove dead code from custom apps#5917
lkostrowski merged 11 commits intomainfrom
remove-dead-code-4

Conversation

@lkostrowski
Copy link
Member

Summary

  • Removed 16 unused custom app component files (~1,062 lines of code)
  • Updated 4 extension components to remove obsolete imports
  • Cleaned up unused styles, dialogs, and skeleton components

Changes

Deleted files:

  • Custom app creation, details, and token management components
  • Webhook management dialogs and lists
  • Skeleton loading components
  • Associated style files

Modified files:

  • CustomExtensionDefaultToken.tsx
  • CustomExtensionDetailsPage.tsx
  • CustomExtensionInformation.tsx
  • CustomExtensionTokens.tsx

🤖 Generated with Claude Code

@lkostrowski lkostrowski requested a review from a team as a code owner October 1, 2025 08:17
@lkostrowski lkostrowski requested review from Copilot, kzuraw and witoszekdev and removed request for Copilot October 1, 2025 08:17
@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2025

⚠️ No Changeset found

Latest commit: 24fa283

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
saleor-dashboard-storybook Ignored Ignored Preview Oct 1, 2025 9:15am

@lkostrowski lkostrowski added the skip changeset Use if your changes doesn't need entry in changelog label Oct 1, 2025
@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.69%. Comparing base (becc31e) to head (24fa283).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ensionDefaultToken/CustomExtensionDefaultToken.tsx 0.00% 1 Missing ⚠️
...xtensionDetailsPage/CustomExtensionDetailsPage.tsx 0.00% 1 Missing ⚠️
...xtensionInformation/CustomExtensionInformation.tsx 0.00% 1 Missing ⚠️
...ts/CustomExtensionTokens/CustomExtensionTokens.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5917      +/-   ##
==========================================
+ Coverage   39.57%   39.69%   +0.11%     
==========================================
  Files        2640     2624      -16     
  Lines       41785    41664     -121     
  Branches     9092     9058      -34     
==========================================
  Hits        16538    16538              
+ Misses      25220    25099     -121     
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot temporarily deployed to pr-5917 October 1, 2025 08:22 Destroyed
Copilot AI review requested due to automatic review settings October 1, 2025 08:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes dead code from custom apps by deleting 16 unused component files and cleaning up related imports and styles. The purpose is to reduce the codebase by approximately 1,062 lines of unused code while updating remaining components to use consistent naming conventions.

Key changes:

  • Deleted unused custom app components including creation, details, token management, webhook management, and skeleton components
  • Updated displayName properties in 4 remaining components for consistent naming
  • Removed associated translation messages from the locale file

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.

Show a summary per file
File Description
CustomExtensionTokens.tsx Updated displayName to match component name
CustomExtensionInformation.tsx Updated displayName to match component name
CustomExtensionDetailsPage.tsx Updated displayName with inconsistent naming
CustomExtensionDefaultToken.tsx Updated displayName to match component name
Multiple deleted files Removed unused custom app components, styles, and dialogs
locale/defaultMessages.json Removed unused translation messages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lkostrowski lkostrowski merged commit 94c5a38 into main Oct 1, 2025
11 of 13 checks passed
@lkostrowski lkostrowski deleted the remove-dead-code-4 branch October 1, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants