Skip to content

Comments

Rename main QA workflow to main / pin node 20 / update codecov serttings#5921

Merged
kzuraw merged 5 commits intomainfrom
fix-main-qa-workflow
Oct 1, 2025
Merged

Rename main QA workflow to main / pin node 20 / update codecov serttings#5921
kzuraw merged 5 commits intomainfrom
fix-main-qa-workflow

Conversation

@kzuraw
Copy link
Contributor

@kzuraw kzuraw commented Oct 1, 2025

Scope of the change

  • I confirm I added ripples for changes (see src/ripples) or my feature doesn't contain any user-facing changes
  • I used analytics "trackEvent" for important events

Copilot AI review requested due to automatic review settings October 1, 2025 12:19
@kzuraw kzuraw added the skip changeset Use if your changes doesn't need entry in changelog label Oct 1, 2025
@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2025

⚠️ No Changeset found

Latest commit: efdf661

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
saleor-dashboard-storybook Ignored Ignored Preview Oct 1, 2025 1:59pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the GitHub Actions workflow configuration by renaming the main QA workflow file, updating Node.js version pinning, and enhancing Codecov settings. The changes streamline CI/CD operations and improve code coverage reporting.

  • Renamed .github/workflows/test.yml to .github/workflows/main.yml with simplified trigger conditions
  • Updated Node.js version from 20 to 20.19 in .nvmrc for better version specificity
  • Enhanced Codecov configuration with patch coverage settings and expanded ignore patterns

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/test.yml Removed old QA workflow file
.github/workflows/main.yml Added new streamlined QA workflow with updated actions and simplified conditions
.nvmrc Updated Node.js version from 20 to 20.19 for more specific version pinning
codecov.yml Added patch coverage settings and expanded ignore patterns for better coverage reporting

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.94%. Comparing base (854a80b) to head (efdf661).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5921      +/-   ##
==========================================
+ Coverage   39.64%   39.94%   +0.30%     
==========================================
  Files        2582     2486      -96     
  Lines       40888    40423     -465     
  Branches     8888     9211     +323     
==========================================
- Hits        16210    16147      -63     
+ Misses      24651    23048    -1603     
- Partials       27     1228    +1201     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot temporarily deployed to pr-5921 October 1, 2025 12:23 Destroyed
Copilot AI review requested due to automatic review settings October 1, 2025 12:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kzuraw kzuraw marked this pull request as ready for review October 1, 2025 12:31
@kzuraw kzuraw requested a review from a team as a code owner October 1, 2025 12:31
@kzuraw kzuraw enabled auto-merge (squash) October 1, 2025 13:59
@kzuraw kzuraw merged commit f98d15e into main Oct 1, 2025
16 checks passed
@kzuraw kzuraw deleted the fix-main-qa-workflow branch October 1, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants