Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes old exports and consolidates code structure by moving Filter-related types to a centralized location, removing unused utilities and components, and updating import paths throughout the codebase.
- Centralized Filter types to
@dashboard/components/Filter/types - Removed unused utilities, components, and URL constants
- Consolidated functionality from custom-apps into extensions module
Reviewed Changes
Copilot reviewed 83 out of 84 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| testUtils/filters.ts | Updated import path for IFilter type |
| src/utils/maps.ts | Removed unused import and mapPersonNodeToChoice function |
| src/utils/handlers/filterHandlers.ts | Updated import path for IFilter type |
| src/utils/filters/filters.ts | Updated import path for Filter types |
| src/utils/filters/fields.ts | Updated import path for Filter types |
| src/types.ts | Updated import path for Filter types |
| src/staff/views/StaffList/filters.ts | Updated import path for Filter types |
| src/staff/components/StaffListPage/filters.ts | Updated import path for IFilter type |
| src/products/views/ProductList/filters.ts | Updated import path for Filter types |
| src/products/components/ProductListPage/ProductListPage.tsx | Updated import path for FilterElement type |
| src/productTypes/views/ProductTypeList/filters.ts | Updated import path for FilterElement type |
| src/productTypes/components/ProductTypeListPage/filters.ts | Updated import path for IFilter type |
| src/plugins/urls.ts | Changed PluginUrlDialog from export to internal type |
| src/orders/views/OrderList/filters.ts | Updated import path for Filter types |
| src/orders/views/OrderDraftList/filters.ts | Updated import path for FilterElement type |
| src/orders/components/OrderDraftListPage/filters.ts | Updated import path for IFilter type |
| src/modeling/views/PageList/filters.ts | Updated import path for FilterElement type |
| src/misc.ts | Removed unused decimal function |
| src/index.tsx | Removed unused imports and replaced hardcoded paths for redirects |
| src/hooks/useFilterHandlers.ts | Updated import path for IFilter type |
| src/hooks/useChannelsSearch.ts | Removed unused imports and interface |
| src/giftCards/GiftCardsList/providers/GiftCardListProvider/GiftCardListProvider.tsx | Updated import path for IFilter type |
| src/giftCards/GiftCardsList/filters.ts | Updated import path for FilterElement type |
| src/giftCards/GiftCardsList/GiftCardsListDatagrid/GiftCardsListDatagrid.tsx | Updated import to named export for TablePagination |
| src/extensions/views/EditCustomExtension/components/WebhooksList/WebhooksList.tsx | Updated import path for isUnnamed utility |
| src/extensions/utils.tsx | Added utilities moved from custom-apps module |
| src/extensions/urls.ts | Added types moved from custom-apps module |
| src/extensions/queries.ts | Added query moved from custom-apps module |
| src/extensions/index.tsx | Updated import path for CustomAppDetailsUrlQueryParams |
| src/extensions/handlers.ts | Updated import paths for utilities |
| src/extensions/components/WebhookDetailsPage/messages.ts | Updated import path for isUnnamed utility |
| src/extensions/components/WebhookDetailsPage/WebhookDetailsPage.tsx | Updated import paths for handlers and types |
| src/discounts/views/VoucherList/filters.ts | Updated import path for Filter types |
| src/discounts/views/SaleList/sort.ts | Removed unused sort utility function |
| src/discounts/views/SaleList/filters.ts | Updated import path for Filter types |
| src/discounts/views/SaleDetails/types.ts | Removed unused constant |
| src/discounts/urls.ts | Changed exports to internal types and removed unused types |
| src/discounts/components/VoucherListPage/filters.ts | Updated import path for IFilter type |
| src/discounts/components/SaleSummary/styles.ts | Removed unused styles file |
| src/discounts/components/SaleSummary/index.ts | Removed unused index file |
| src/discounts/components/SaleSummary/SaleSummary.tsx | Removed unused component |
| src/discounts/components/SaleListPage/filters.ts | Updated import path and changed interface to internal |
| src/discounts/components/SaleListDatagrid/messages.ts | Removed unused messages file |
| src/discounts/components/SaleListDatagrid/index.tsx | Removed unused index file |
| src/discounts/components/SaleListDatagrid/datagrid.ts | Removed unused datagrid utilities |
| src/discounts/components/SaleListDatagrid/SaleListDatagrid.tsx | Removed unused component |
| src/customers/views/CustomerList/filters.ts | Updated import path for FilterElement type |
| src/customers/components/CustomerListPage/filters.ts | Updated import path for IFilter type |
| src/custom-apps/utils.tsx | Removed file - utilities moved to extensions |
| src/custom-apps/urls.ts | Removed file - types moved to extensions |
| src/custom-apps/queries.ts | Removed file - queries moved to extensions |
| src/custom-apps/components/PermissionAlert/utils.ts | Removed unused permission alert utilities |
| src/custom-apps/components/PermissionAlert/utils.test.ts | Removed unused test file |
| src/custom-apps/components/PermissionAlert/PermissionAlert.tsx | Removed unused component |
| src/custom-apps/components/PermissionAlert/PermissionAlert.test.tsx | Removed unused test file |
| src/components/Timeline/TimelineNote.tsx | Removed default export |
| src/components/Timeline/TimelineNote.test.tsx | Updated import to named export |
| src/components/Timeline/TimelineEvent.tsx | Removed default export |
| src/components/TablePagination/index.ts | Removed default export |
| src/components/TablePagination/TablePaginationWithContext.tsx | Updated import to named export |
| src/components/TablePagination/TablePagination.tsx | Removed default export |
| src/components/Filter/utils.ts | Removed unused import and getSelectedFiltersAmount function |
| src/components/Filter/index.ts | Removed entire index file |
| src/components/Filter/FilterContent/index.tsx | Removed index file |
| src/components/Filter/FilterContent/FilterSingleSelectField.tsx | Updated import paths for Filter types |
| src/components/Filter/FilterContent/FilterNumericField.tsx | Updated import paths for Filter types |
| src/components/Filter/FilterContent/FilterErrorsList.tsx | Removed default export |
| src/components/Filter/FilterContent/FilterDateTimeField.tsx | Updated import paths for Filter types |
| src/components/Filter/FilterContent/FilterContentHeader.tsx | Removed default export |
| src/components/Filter/FilterContent/FilterContentBodyNameField.tsx | Removed default export |
| src/components/Filter/FilterContent/FilterContentBody.tsx | Removed default export |
| src/components/Filter/FilterContent/FilterContent.tsx | Updated import paths and removed default export |
| src/components/Filter/Filter.tsx | Removed entire Filter component |
| src/components/AppLayout/ListFilters/utils.ts | Updated import path for Filter types |
| src/components/AppLayout/ListFilters/utils.test.ts | Updated import path for Filter types |
| src/components/AppLayout/ListFilters/components/FiltersSelect.tsx | Updated import paths for Filter types |
| src/components/AppLayout/ListFilters/ListFilters.tsx | Updated import path for Filter types |
| src/collections/views/CollectionList/filters.ts | Updated import path for Filter types |
| src/collections/components/CollectionListPage/filters.ts | Updated import path for IFilter type |
| src/attributes/views/AttributeList/filters.ts | Updated import path for FilterElement type |
| src/attributes/components/AttributeValues/AttributeValues.tsx | Updated import to named export for TablePagination |
| src/attributes/components/AttributeListPage/filters.ts | Updated import path for IFilter type |
| locale/defaultMessages.json | Removed unused XZR590 message |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5923 +/- ##
==========================================
+ Coverage 39.94% 40.04% +0.10%
==========================================
Files 2486 2472 -14
Lines 40423 40153 -270
Branches 8880 9144 +264
==========================================
- Hits 16147 16080 -67
+ Misses 24249 24046 -203
Partials 27 27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 91 out of 94 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/extensions/index.tsx:1
- The import of
CustomAppDetailsUrlQueryParamsandPluginUrlQueryParamsfrom extensions/urls should be verified against the actual exports in that file. The moved types may have different naming or may not exist in the target location.
import SectionRoute from "@dashboard/auth/components/SectionRoute";
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Summary
This PR removes unused code and reorganizes the codebase to improve maintainability:
Filter.tsxcomponent and moved to usingFilterContentdirectly with the new filter systemextensionsmodule where they belongSaleListDatagridandSaleSummary(old discount UI)PermissionAlertcomponent and related utilitiesChanges by module
Filter system refactoring
src/components/Filter/Filter.tsx(177 lines)FilterContent,FilterContentBody,FilterContentHeader,FilterErrorsList, andFilterContentBodyNameFieldfrom default to named exports@dashboard/components/Filter/typesExtensions/Custom Apps consolidation
custom-apps/toextensions/extensions/modulecustom-apps/directoriesComponent cleanup
SaleListDatagridcomponent (264 lines)SaleSummarycomponent (110 lines)PermissionAlertcomponent and utilities (368 lines)ScrollableContenttoChannelsAvailabilityMenuContentdirectoryUtilities cleanup
src/utils/maps.tsgetSelectedFiltersAmountfrom filter utilsImpact
🤖 Generated with Claude Code