Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR backports EditorJS fixes to handle compatibility between different versions of the @editorjs/list plugin. The changes address format differences where newer versions (v2.0.0+) use object-based list items while legacy versions use string arrays.
- Convert EditorJS list blocks from new object format to legacy string format for backward compatibility
- Update EditorJS package versions to specific non-caret versions
- Fix icon import and styling issues for the rich text editor
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/richText/useRichText.ts | Added conversion function call to transform list blocks before returning editor data |
| src/components/RichTextEditor/utils.ts | Added utility function to convert EditorJS list blocks from new to legacy format |
| src/components/RichTextEditor/utils.test.ts | Added comprehensive test coverage for the list block conversion function |
| src/components/RichTextEditor/RichTextEditor.tsx | Applied list block conversion to onChange handler |
| src/components/RichTextEditor/consts.ts | Updated strikethrough icon import to use named export |
| src/icons/StrikethroughIcon.tsx | Updated icon SVG and changed to named export with comment attribution |
| src/components/RichTextEditor/styles.ts | Removed absolute positioning styles and added overflow hidden for popover items |
| package.json | Updated EditorJS packages to specific versions without caret ranges |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kzuraw
added
the
skip changeset
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5925 +/- ##
==========================================
+ Coverage 40.04% 40.06% +0.01%
==========================================
Files 2472 2473 +1
Lines 40153 40170 +17
Branches 8814 9151 +337
==========================================
+ Hits 16080 16093 +13
+ Misses 24046 22867 -1179
- Partials 27 1210 +1183 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Differences Found✅ No packages or licenses were added. SummaryExpand
|
- Upgraded @saleor/macaw-ui-next from 1.3.2 to 1.3.5 - Moved EditorJS list block conversion to save() method in ReactEditorJS for better architecture - Removed redundant list conversion calls from RichTextEditor and useRichText - Implemented dangerouslyLowLevelInstance in ClientEditorCore (EditorCore interface requirement) - Removed unnecessary @ts-expect-error directive for List class (fixed by upgrade) This ensures list block conversion happens once at the save level rather than multiple times in consuming components, fixing issues with lists in descriptions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lkostrowski
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of the change
Backport of #5911 & #5927