Skip to content

Fix wrong output for 3.22 release#5930

Merged
kzuraw merged 1 commit intomainfrom
fix-ci-cd-release-1
Oct 2, 2025
Merged

Fix wrong output for 3.22 release#5930
kzuraw merged 1 commit intomainfrom
fix-ci-cd-release-1

Conversation

@kzuraw
Copy link
Contributor

@kzuraw kzuraw commented Oct 2, 2025

Scope of the change

  • I confirm I added ripples for changes (see src/ripples) or my feature doesn't contain any user-facing changes
  • I used analytics "trackEvent" for important events

@kzuraw kzuraw requested a review from a team as a code owner October 2, 2025 10:07
@kzuraw kzuraw added the skip changeset Use if your changes doesn't need entry in changelog label Oct 2, 2025
@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2025

⚠️ No Changeset found

Latest commit: eb2bf35

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
saleor-dashboard-storybook Ignored Ignored Oct 2, 2025 10:07am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the branch name resolution for release automation by properly handling the BRANCH_NAME parameter in GitHub workflows. The changes ensure that the correct branch is used when creating pull request checks and passing parameters between workflow jobs.

  • Adds BRANCH_NAME input parameter to workflows for proper branch identification
  • Updates PR head reference logic to use BRANCH_NAME when available, falling back to VERSION
  • Consolidates environment variable setup and improves variable naming consistency

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/run-tests-on-release.yml Adds BRANCH_NAME input parameter and updates PR_HEAD logic to use it
.github/workflows/deploy-staging-and-prepare-release.yaml Refactors environment setup, renames VERSION to BRANCH_NAME, and passes BRANCH_NAME between jobs

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kzuraw kzuraw merged commit a95619e into main Oct 2, 2025
17 of 21 checks passed
@kzuraw kzuraw deleted the fix-ci-cd-release-1 branch October 2, 2025 10:08
@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.04%. Comparing base (db00a0c) to head (eb2bf35).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #5930     +/-   ##
=========================================
  Coverage   40.04%   40.04%             
=========================================
  Files        2472     2472             
  Lines       40153    40153             
  Branches     9144     8814    -330     
=========================================
  Hits        16080    16080             
- Misses      22864    24046   +1182     
+ Partials     1209       27   -1182     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants