Skip to content

Fix workflow branch reference for Playwright tests#5931

Merged
kzuraw merged 3 commits intomainfrom
fix/workflow-branch-reference
Oct 2, 2025
Merged

Fix workflow branch reference for Playwright tests#5931
kzuraw merged 3 commits intomainfrom
fix/workflow-branch-reference

Conversation

@kzuraw
Copy link
Contributor

@kzuraw kzuraw commented Oct 2, 2025

Summary

  • Pass BRANCH_NAME to the run-pw-tests job outputs
  • Use BRANCH_NAME instead of VERSION for checkout reference in Playwright tests step

This ensures that Playwright tests run against the correct branch reference.

Test plan

  • Verify workflow runs successfully on release branches
  • Confirm Playwright tests checkout the correct branch

🤖 Generated with Claude Code

Use BRANCH_NAME instead of VERSION for checkout to ensure tests run against the correct branch reference.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@kzuraw kzuraw requested a review from a team as a code owner October 2, 2025 10:40
@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2025

⚠️ No Changeset found

Latest commit: d1af546

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
saleor-dashboard-storybook Ignored Ignored Preview Oct 2, 2025 11:24am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes workflow branch reference issue where Playwright tests were incorrectly checking out code using a version tag instead of the branch name, ensuring tests run against the correct code branch.

  • Added BRANCH_NAME output to the add-check-and-prepare-instance job
  • Updated Playwright tests checkout reference to use BRANCH_NAME instead of VERSION

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kzuraw kzuraw added the skip changeset Use if your changes doesn't need entry in changelog label Oct 2, 2025
@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.04%. Comparing base (637c291) to head (d1af546).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #5931     +/-   ##
=========================================
  Coverage   40.04%   40.04%             
=========================================
  Files        2472     2472             
  Lines       40153    40153             
  Branches     9144     8814    -330     
=========================================
  Hits        16080    16080             
- Misses      22864    24046   +1182     
+ Partials     1209       27   -1182     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI review requested due to automatic review settings October 2, 2025 11:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kzuraw kzuraw merged commit d450f6a into main Oct 2, 2025
15 checks passed
@kzuraw kzuraw deleted the fix/workflow-branch-reference branch October 2, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants