Skip to content

Fix error on Order details page#5934

Merged
witoszekdev merged 5 commits intomainfrom
fix-order-details-error
Oct 3, 2025
Merged

Fix error on Order details page#5934
witoszekdev merged 5 commits intomainfrom
fix-order-details-error

Conversation

@witoszekdev
Copy link
Member

@witoszekdev witoszekdev commented Oct 2, 2025

Scope of the change

This PR fixes error when opening order draft details. It also adds strict mode in a file

  • I confirm I added ripples for changes (see src/ripples) or my feature doesn't contain any user-facing changes
  • I used analytics "trackEvent" for important events

Copilot AI review requested due to automatic review settings October 2, 2025 12:57
@witoszekdev witoszekdev requested a review from a team as a code owner October 2, 2025 12:57
@vercel
Copy link

vercel bot commented Oct 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
saleor-dashboard-storybook Ignored Ignored Preview Oct 3, 2025 0:06am

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2025

⚠️ No Changeset found

Latest commit: 2c1f1cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@witoszekdev witoszekdev added the skip changeset Use if your changes doesn't need entry in changelog label Oct 2, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes TypeScript strict mode compatibility issues in order details page functionality by adding proper null checks and type annotations.

  • Removed @ts-strict-ignore directive to enable strict TypeScript checking
  • Added comprehensive null safety guards throughout order data handling functions
  • Enhanced type annotations for better type safety and null handling

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/orders/utils/data.ts Added null checks, improved type safety, and removed TypeScript strict mode ignore directive
src/orders/components/OrderReturnPage/utils.tsx Enhanced return type annotations and added explicit type parameters for reduce operations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 70.90909% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.07%. Comparing base (4915a19) to head (2c1f1cc).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/orders/utils/data.ts 68.62% 16 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #5934    +/-   ##
========================================
  Coverage   40.06%   40.07%            
========================================
  Files        2473     2473            
  Lines       40171    40190    +19     
  Branches     8821     9171   +350     
========================================
+ Hits        16096    16107    +11     
- Misses      24048    24056     +8     
  Partials       27       27            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@witoszekdev witoszekdev enabled auto-merge (squash) October 3, 2025 12:06
Copilot AI review requested due to automatic review settings October 3, 2025 12:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@witoszekdev witoszekdev merged commit 9e2d21c into main Oct 3, 2025
14 checks passed
@witoszekdev witoszekdev deleted the fix-order-details-error branch October 3, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants