Skip to content

[3.21] Show last used bagde only if there are more than one login method#5948

Merged
kzuraw merged 3 commits into3.21from
eng-821-last-used-only-method-321
Oct 7, 2025
Merged

[3.21] Show last used bagde only if there are more than one login method#5948
kzuraw merged 3 commits into3.21from
eng-821-last-used-only-method-321

Conversation

@kzuraw
Copy link
Contributor

@kzuraw kzuraw commented Oct 7, 2025

Scope of the change

Backport of #5947

  • I confirm I added ripples for changes (see src/ripples) or my feature doesn't contain any user-facing changes
  • I used analytics "trackEvent" for important events

Copilot AI review requested due to automatic review settings October 7, 2025 09:45
@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2025

🦋 Changeset detected

Latest commit: 0ec73f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
saleor-dashboard-storybook Ignored Ignored Preview Oct 7, 2025 9:47am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Backport to conditionally display the last login indicator for password logins only when multiple authentication methods are available.

  • Introduces a helper constant to clarify the display condition for the last login indicator.
  • Replaces inline conditional with the new variable.
  • Adds a changeset entry (with a spelling issue).

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/auth/components/LoginPage/LoginPage.tsx Adds explicit boolean for showing last login indicator and uses it in JSX.
.changeset/smart-singers-open.md Adds release note (contains spelling and minor grammatical issues).

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.17%. Comparing base (11bbfaf) to head (0ec73f4).
⚠️ Report is 1 commits behind head on 3.21.

Additional details and impacted files
@@           Coverage Diff            @@
##             3.21    #5948    +/-   ##
========================================
  Coverage   65.17%   65.17%            
========================================
  Files        1446     1446            
  Lines       25065    25066     +1     
  Branches     5112     5113     +1     
========================================
+ Hits        16335    16336     +1     
- Misses       8139     8686   +547     
+ Partials      591       44   -547     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kzuraw kzuraw marked this pull request as ready for review October 7, 2025 09:52
@kzuraw kzuraw requested a review from a team as a code owner October 7, 2025 09:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kzuraw kzuraw merged commit ab0fbd2 into 3.21 Oct 7, 2025
19 checks passed
@kzuraw kzuraw deleted the eng-821-last-used-only-method-321 branch October 7, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants