Skip to content

Fix visual regressions on refund with line items view#5951

Merged
witoszekdev merged 19 commits intomainfrom
eng-838-fix-visual-regressions
Oct 9, 2025
Merged

Fix visual regressions on refund with line items view#5951
witoszekdev merged 19 commits intomainfrom
eng-838-fix-visual-regressions

Conversation

@witoszekdev
Copy link
Member

@witoszekdev witoszekdev commented Oct 7, 2025

Fixed visual regressions and bugs on granted refund page.

  • Added proper padding on refund amount summary
  • fixed spacing in right sidebar
  • fixed text overflow in transaction card
CleanShot.2025-10-09.at.14.32.01.mp4

Copilot AI review requested due to automatic review settings October 7, 2025 15:43
@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2025

🦋 Changeset detected

Latest commit: 9d6cdb9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
saleor-dashboard-storybook Ignored Ignored Preview Oct 9, 2025 1:02pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes visual regressions in the refund with line items view by addressing layout spacing and margin issues.

  • Replaced flex layout with CSS grid for better alignment of refund summary items
  • Added consistent spacing between sidebar components using gap property
  • Fixed missing margin on warning component in manual transaction refund page

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
OrderTransactionSummary.tsx Refactored layout from flex to grid system with custom line separator component
OrderTransactionRefundPage.tsx Added gap spacing to sidebar container and removed redundant margins
OrderManualTransactionRefundPage.tsx Added missing top margin to warning component

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 41.66667% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.08%. Comparing base (99a4948) to head (9d6cdb9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ts/OrderTransactionTiles/OrderTransactionTiles.tsx 0.00% 9 Missing ⚠️
src/components/Sidebar/SidebarContext.tsx 60.00% 6 Missing ⚠️
...ansactionRefundSummary/OrderTransactionSummary.tsx 0.00% 5 Missing ⚠️
...ansactionRefundPage/OrderTransactionRefundPage.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5951      +/-   ##
==========================================
+ Coverage   40.07%   40.08%   +0.01%     
==========================================
  Files        2473     2474       +1     
  Lines       40234    40256      +22     
  Branches     8854     8856       +2     
==========================================
+ Hits        16124    16138      +14     
- Misses      24083    24091       +8     
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI review requested due to automatic review settings October 8, 2025 14:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings October 9, 2025 11:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings October 9, 2025 11:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings October 9, 2025 12:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings October 9, 2025 12:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@witoszekdev witoszekdev marked this pull request as ready for review October 9, 2025 12:24
@witoszekdev witoszekdev requested a review from a team as a code owner October 9, 2025 12:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings October 9, 2025 13:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@witoszekdev witoszekdev enabled auto-merge (squash) October 9, 2025 13:04
@witoszekdev witoszekdev merged commit 7e2ac0a into main Oct 9, 2025
14 checks passed
@witoszekdev witoszekdev deleted the eng-838-fix-visual-regressions branch October 9, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants