Remove Content Attributes from All Products column picker#5959
Remove Content Attributes from All Products column picker#5959IKarbowiak merged 9 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: f0d7f07 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds attribute type filtering to the products list column picker to specifically show only product type attributes, removing content attributes from the available columns.
- Modified GraphQL queries to accept
AttributeTypeEnumparameter - Updated all query calls to filter by
PRODUCT_TYPEattributes - Added type safety with proper TypeScript interfaces
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/products/views/ProductList/ProductList.tsx | Added AttributeTypeEnum import and type filter parameter |
| src/products/queries.ts | Updated GraphQL queries to include type filtering |
| src/products/components/ProductListDatagrid/datagrid.ts | Added type parameter to attribute query functions |
| src/products/components/ProductListDatagrid/ProductListDatagrid.tsx | Updated search query to include product type filter |
| src/graphql/types.generated.ts | Generated TypeScript types for new query parameters |
| src/graphql/hooks.generated.ts | Generated Apollo hooks with updated query signatures |
Comments suppressed due to low confidence (1)
src/products/components/ProductListDatagrid/datagrid.ts:557
- The
onPreviousPagefunction is missing the requiredtypeparameter that was added to the query variables. This will cause a GraphQL error when pagination is used.
const onPreviousPage = (query: string) =>
queryAvailableColumnsAttributes({
variables: {
search: query,
before: availableColumnsAttributesData.data?.attributes?.pageInfo.startCursor,
last: 10,
first: null,
after: null,
},
});
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/products/components/ProductListDatagrid/ProductListDatagrid.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
src/products/components/ProductListDatagrid/datagrid.ts:1
- The
onPreviousPagefunction is missing thetypeparameter in its query variables. This will cause the previous page functionality to fail as it doesn't include the required AttributeTypeEnum.PRODUCT_TYPE filter.
// @ts-strict-ignore
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5959 +/- ##
=========================================
Coverage 39.41% 39.42%
=========================================
Files 2438 2438
Lines 39742 39744 +2
Branches 8739 9065 +326
=========================================
+ Hits 15666 15668 +2
+ Misses 24050 22869 -1181
- Partials 26 1207 +1181 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7d92855 to
376d8ec
Compare
376d8ec to
090815d
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
* Release 3.22 (#5974) (#5975) Co-authored-by: saleor-deployments[bot] <97954499+saleor-deployments[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Remove Content Attributes from All Products column picker (#5959) * Remove Content Attributes from All Products column picker * Update changeset * Fix linters * Update .changeset/large-showers-check.md Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com> --------- Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com> * Remove dead code and reorganize apps/extensions GraphQL layer (#5976) * move file * remove some unused queries * cleanup queries * move graphql * drop old files * changeset * Remove unused sale GraphQL operations (#5978) * remove mutation * remove some mutations and queries * changeset * Complete apps-to-extensions refactor by removing legacy code (#5979) * drop old appframe * remove app hooks * remove appActionsHandler * drop apps/ folder * fix imports * ts fixes * add tests --------- Co-authored-by: saleor-deployments[bot] <97954499+saleor-deployments[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Iga Karbowiak <40886528+IKarbowiak@users.noreply.github.com> Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com>
Scope of the change
Remove Content Attributes from All Products column picker.
Now the column picker shows only

product_typeattributes