Skip to content

Remove Content Attributes from All Products column picker#5959

Merged
IKarbowiak merged 9 commits intomainfrom
eng-590-update-attribute-column-picker-on-all-products
Oct 14, 2025
Merged

Remove Content Attributes from All Products column picker#5959
IKarbowiak merged 9 commits intomainfrom
eng-590-update-attribute-column-picker-on-all-products

Conversation

@IKarbowiak
Copy link
Member

@IKarbowiak IKarbowiak commented Oct 10, 2025

Scope of the change

Remove Content Attributes from All Products column picker.

Now the column picker shows only product_type attributes
image

  • I confirm I added ripples for changes (see src/ripples) or my feature doesn't contain any user-facing changes
  • I used analytics "trackEvent" for important events

Copilot AI review requested due to automatic review settings October 10, 2025 07:57
@IKarbowiak IKarbowiak requested a review from a team as a code owner October 10, 2025 07:57
@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2025

🦋 Changeset detected

Latest commit: f0d7f07

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
saleor-dashboard-storybook Ignored Ignored Preview Oct 14, 2025 10:25am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds attribute type filtering to the products list column picker to specifically show only product type attributes, removing content attributes from the available columns.

  • Modified GraphQL queries to accept AttributeTypeEnum parameter
  • Updated all query calls to filter by PRODUCT_TYPE attributes
  • Added type safety with proper TypeScript interfaces

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/products/views/ProductList/ProductList.tsx Added AttributeTypeEnum import and type filter parameter
src/products/queries.ts Updated GraphQL queries to include type filtering
src/products/components/ProductListDatagrid/datagrid.ts Added type parameter to attribute query functions
src/products/components/ProductListDatagrid/ProductListDatagrid.tsx Updated search query to include product type filter
src/graphql/types.generated.ts Generated TypeScript types for new query parameters
src/graphql/hooks.generated.ts Generated Apollo hooks with updated query signatures
Comments suppressed due to low confidence (1)

src/products/components/ProductListDatagrid/datagrid.ts:557

  • The onPreviousPage function is missing the required type parameter that was added to the query variables. This will cause a GraphQL error when pagination is used.
  const onPreviousPage = (query: string) =>
    queryAvailableColumnsAttributes({
      variables: {
        search: query,
        before: availableColumnsAttributesData.data?.attributes?.pageInfo.startCursor,
        last: 10,
        first: null,
        after: null,
      },
    });

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings October 10, 2025 08:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

src/products/components/ProductListDatagrid/datagrid.ts:1

  • The onPreviousPage function is missing the type parameter in its query variables. This will cause the previous page functionality to fail as it doesn't include the required AttributeTypeEnum.PRODUCT_TYPE filter.
// @ts-strict-ignore

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.42%. Comparing base (fc59fd7) to head (f0d7f07).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #5959     +/-   ##
=========================================
  Coverage   39.41%   39.42%             
=========================================
  Files        2438     2438             
  Lines       39742    39744      +2     
  Branches     8739     9065    +326     
=========================================
+ Hits        15666    15668      +2     
+ Misses      24050    22869   -1181     
- Partials       26     1207   +1181     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@IKarbowiak IKarbowiak force-pushed the eng-590-update-attribute-column-picker-on-all-products branch from 7d92855 to 376d8ec Compare October 10, 2025 08:24
@IKarbowiak IKarbowiak force-pushed the eng-590-update-attribute-column-picker-on-all-products branch from 376d8ec to 090815d Compare October 10, 2025 08:29
Copilot AI review requested due to automatic review settings October 10, 2025 12:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

witoszekdev
witoszekdev previously approved these changes Oct 13, 2025
Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com>
Copilot AI review requested due to automatic review settings October 13, 2025 11:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings October 14, 2025 09:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@IKarbowiak IKarbowiak merged commit 83ee918 into main Oct 14, 2025
16 checks passed
@IKarbowiak IKarbowiak deleted the eng-590-update-attribute-column-picker-on-all-products branch October 14, 2025 10:36
lkostrowski added a commit that referenced this pull request Oct 15, 2025
* Release 3.22 (#5974) (#5975)

Co-authored-by: saleor-deployments[bot] <97954499+saleor-deployments[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Remove Content Attributes from All Products column picker (#5959)

* Remove Content Attributes from All Products column picker

* Update changeset

* Fix linters

* Update .changeset/large-showers-check.md

Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com>

---------

Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com>

* Remove dead code and reorganize apps/extensions GraphQL layer (#5976)

* move file

* remove some unused queries

* cleanup queries

* move graphql

* drop old files

* changeset

* Remove unused sale GraphQL operations (#5978)

* remove mutation

* remove some mutations and queries

* changeset

* Complete apps-to-extensions refactor by removing legacy code (#5979)

* drop old appframe

* remove app hooks

* remove appActionsHandler

* drop apps/ folder

* fix imports

* ts fixes

* add tests

---------

Co-authored-by: saleor-deployments[bot] <97954499+saleor-deployments[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Iga Karbowiak <40886528+IKarbowiak@users.noreply.github.com>
Co-authored-by: Jonatan Witoszek <jonatanwitoszek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants