Skip to content

Revert CI/CD workflow changes#5961

Merged
kzuraw merged 1 commit intomainfrom
revert-ci-cd-workflow-changes
Oct 10, 2025
Merged

Revert CI/CD workflow changes#5961
kzuraw merged 1 commit intomainfrom
revert-ci-cd-workflow-changes

Conversation

@kzuraw
Copy link
Contributor

@kzuraw kzuraw commented Oct 10, 2025

Scope of the change

  • I confirm I added ripples for changes (see src/ripples) or my feature doesn't contain any user-facing changes
  • I used analytics "trackEvent" for important events

Copilot AI review requested due to automatic review settings October 10, 2025 09:18
@kzuraw kzuraw added the skip changeset Use if your changes doesn't need entry in changelog label Oct 10, 2025
@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2025

⚠️ No Changeset found

Latest commit: f255251

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kzuraw kzuraw marked this pull request as ready for review October 10, 2025 09:18
@kzuraw kzuraw requested a review from a team as a code owner October 10, 2025 09:18
@vercel
Copy link

vercel bot commented Oct 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
saleor-dashboard-storybook Ignored Ignored Oct 10, 2025 9:18am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts CI/CD workflow changes by removing the BRANCH_NAME parameter and its associated logic from GitHub Actions workflows. The changes simplify the workflows by eliminating the branch name input parameter and reverting to using version-based references instead.

Key changes:

  • Removal of BRANCH_NAME input parameter and environment variable from both workflows
  • Simplification of checkout references to use VERSION instead of BRANCH_NAME
  • Updated environment variable derivation logic to use VERSION directly

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/run-tests-on-release.yml Removes BRANCH_NAME input parameter and updates PR head and checkout references to use VERSION
.github/workflows/deploy-staging-and-prepare-release.yaml Removes BRANCH_NAME parameter, simplifies environment setup, and updates variable references
Comments suppressed due to low confidence (1)

.github/workflows/deploy-staging-and-prepare-release.yaml:1

  • The checkout reference is using VERSION output, but the job outputs only define MINOR_VERSION and CUSTOM_VERSION. VERSION is not defined in the outputs section, which will cause this reference to be empty.
name: Deploy Dashboard to staging

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kzuraw kzuraw enabled auto-merge (squash) October 10, 2025 09:21
@kzuraw kzuraw merged commit dce7d7c into main Oct 10, 2025
23 checks passed
@kzuraw kzuraw deleted the revert-ci-cd-workflow-changes branch October 10, 2025 09:22
@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.08%. Comparing base (786af16) to head (f255251).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #5961     +/-   ##
=========================================
  Coverage   40.08%   40.08%             
=========================================
  Files        2474     2474             
  Lines       40256    40256             
  Branches     9187     8856    -331     
=========================================
  Hits        16138    16138             
- Misses      22906    24091   +1185     
+ Partials     1212       27   -1185     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants