Migrate npx to pnpx in github workflows#6051
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
There was a problem hiding this comment.
Pull Request Overview
This PR migrates GitHub workflow commands from using npx to pnpx to ensure consistency with the project's pnpm-based package management. The key changes include:
- Replacing
npxwithpnpxfor CLI commands (Saleor CLI, Playwright, depcruise) - Adding pnpm setup steps in composite actions that previously lacked them
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/pr-cleanup.yml |
Updated Saleor CLI command to use pnpx |
.github/workflows/dependency-check.yaml |
Updated depcruise commands to use pnpx |
.github/actions/run-pw-tests/action.yml |
Updated Playwright commands to use pnpx |
.github/actions/prepare-instance/action.yml |
Added pnpm setup and updated most Saleor CLI commands to use pnpx |
.github/actions/prepare-backups-variables/action.yml |
Added pnpm setup and updated Saleor CLI command to use pnpx |
.github/actions/merge-pw-reports/action.yml |
Updated Playwright merge-reports command to use pnpx |
Comments suppressed due to low confidence (1)
.github/actions/prepare-instance/action.yml:50
- Inconsistent use of
npxinstead ofpnpx. This line should usepnpxto be consistent with the migration from npx to pnpx throughout the rest of this file and the PR.
INSTANCE_KEY=$(npx saleor env show "$INSTANCE_NAME" --json | jq .key)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6051 +/- ##
=========================================
Coverage 39.90% 39.90%
=========================================
Files 2402 2402
Lines 39690 39690
Branches 8727 9053 +326
=========================================
Hits 15838 15838
+ Misses 23823 22642 -1181
- Partials 29 1210 +1181 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Scope of the change
Should fix e2e workflows