Skip to content

Comments

Migrate npx to pnpx in github workflows#6051

Merged
lkostrowski merged 1 commit intomainfrom
fix-workflow
Nov 12, 2025
Merged

Migrate npx to pnpx in github workflows#6051
lkostrowski merged 1 commit intomainfrom
fix-workflow

Conversation

@lkostrowski
Copy link
Member

@lkostrowski lkostrowski commented Nov 12, 2025

Scope of the change

Should fix e2e workflows

  • I confirm I added ripples for changes (see src/ripples) or my feature doesn't contain any user-facing changes
  • I used analytics "trackEvent" for important events

Copilot AI review requested due to automatic review settings November 12, 2025 09:07
@lkostrowski lkostrowski requested a review from a team as a code owner November 12, 2025 09:07
@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2025

⚠️ No Changeset found

Latest commit: 1b67f24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
saleor-dashboard-storybook Ignored Ignored Nov 12, 2025 9:07am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates GitHub workflow commands from using npx to pnpx to ensure consistency with the project's pnpm-based package management. The key changes include:

  • Replacing npx with pnpx for CLI commands (Saleor CLI, Playwright, depcruise)
  • Adding pnpm setup steps in composite actions that previously lacked them

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/pr-cleanup.yml Updated Saleor CLI command to use pnpx
.github/workflows/dependency-check.yaml Updated depcruise commands to use pnpx
.github/actions/run-pw-tests/action.yml Updated Playwright commands to use pnpx
.github/actions/prepare-instance/action.yml Added pnpm setup and updated most Saleor CLI commands to use pnpx
.github/actions/prepare-backups-variables/action.yml Added pnpm setup and updated Saleor CLI command to use pnpx
.github/actions/merge-pw-reports/action.yml Updated Playwright merge-reports command to use pnpx
Comments suppressed due to low confidence (1)

.github/actions/prepare-instance/action.yml:50

  • Inconsistent use of npx instead of pnpx. This line should use pnpx to be consistent with the migration from npx to pnpx throughout the rest of this file and the PR.
        INSTANCE_KEY=$(npx saleor env show "$INSTANCE_NAME" --json | jq .key)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.90%. Comparing base (940c2fd) to head (1b67f24).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #6051     +/-   ##
=========================================
  Coverage   39.90%   39.90%             
=========================================
  Files        2402     2402             
  Lines       39690    39690             
  Branches     8727     9053    +326     
=========================================
  Hits        15838    15838             
+ Misses      23823    22642   -1181     
- Partials       29     1210   +1181     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lkostrowski lkostrowski added the skip changeset Use if your changes doesn't need entry in changelog label Nov 12, 2025
@lkostrowski lkostrowski merged commit 086ac66 into main Nov 12, 2025
30 of 36 checks passed
@lkostrowski lkostrowski deleted the fix-workflow branch November 12, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants