Skip to content

Comments

fix pw setup#6057

Merged
lkostrowski merged 1 commit intomainfrom
pw-fix
Nov 12, 2025
Merged

fix pw setup#6057
lkostrowski merged 1 commit intomainfrom
pw-fix

Conversation

@lkostrowski
Copy link
Member

Scope of the change

  • I confirm I added ripples for changes (see src/ripples) or my feature doesn't contain any user-facing changes
  • I used analytics "trackEvent" for important events

Copilot AI review requested due to automatic review settings November 12, 2025 11:44
@lkostrowski lkostrowski requested a review from a team as a code owner November 12, 2025 11:44
@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2025

⚠️ No Changeset found

Latest commit: a749553

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
saleor-dashboard-storybook Ignored Ignored Nov 12, 2025 11:44am

@lkostrowski lkostrowski added the skip changeset Use if your changes doesn't need entry in changelog label Nov 12, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the Playwright authentication setup file by correctly scoping the serial mode configuration within a describe block, which aligns with Playwright's best practices.

  • Wrapped all authentication setup tests in a setup.describe() block
  • Moved setup.describe.configure({ mode: "serial" }) from global scope to inside the describe block
  • Improved code organization by properly scoping variables within the describe block

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.90%. Comparing base (313a42c) to head (a749553).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #6057     +/-   ##
=========================================
  Coverage   39.90%   39.90%             
=========================================
  Files        2402     2402             
  Lines       39690    39690             
  Branches     8727     9053    +326     
=========================================
  Hits        15838    15838             
+ Misses      23823    22642   -1181     
- Partials       29     1210   +1181     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lkostrowski lkostrowski merged commit 230fd4e into main Nov 12, 2025
28 of 33 checks passed
@lkostrowski lkostrowski deleted the pw-fix branch November 12, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants