Skip to content

Comments

Add claude command to fix ts types#6215

Open
lkostrowski wants to merge 1 commit intomainfrom
claude-commands
Open

Add claude command to fix ts types#6215
lkostrowski wants to merge 1 commit intomainfrom
claude-commands

Conversation

@lkostrowski
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 16, 2025 13:55
@lkostrowski lkostrowski requested a review from a team as a code owner December 16, 2025 13:55
@changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2025

⚠️ No Changeset found

Latest commit: 671e089

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lkostrowski lkostrowski enabled auto-merge (squash) December 16, 2025 13:55
@lkostrowski lkostrowski added the skip changeset Use if your changes doesn't need entry in changelog label Dec 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new Claude AI assistant command file that provides instructions for fixing TypeScript type errors in the project. The command file establishes a systematic workflow for identifying and resolving type errors using the project's existing type-checking and linting scripts.

Key changes:

  • Added .claude/commands/fix-types.md with a 4-step workflow for fixing TypeScript type errors

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


Steps:

1. Run `pnpm run check-types:src` or `pnpm run check-types:src paths/to/files` to identify type errors
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command pnpm run check-types:src paths/to/files will not work as intended. The check-types:src script runs tsc --noEmit && tsc-strict, and TypeScript's compiler with the --noEmit flag does not accept file paths as command-line arguments in this way - it uses the configuration from tsconfig.json. Consider removing the path-specific command suggestion or documenting an alternative approach for checking specific files.

Suggested change
1. Run `pnpm run check-types:src` or `pnpm run check-types:src paths/to/files` to identify type errors
1. Run `pnpm run check-types:src` to identify type errors across the entire project.

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.36%. Comparing base (33d7143) to head (671e089).

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6215    +/-   ##
========================================
  Coverage   40.36%   40.36%            
========================================
  Files        2428     2428            
  Lines       40528    40528            
  Branches     8975     9309   +334     
========================================
  Hits        16360    16360            
  Misses      24140    24140            
  Partials       28       28            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@witoszekdev witoszekdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest making it really obvious because Claude often just does as any or as unknown as ... and calls it a day 😆


Steps:

1. Run `pnpm run check-types:src` or `pnpm run check-types:src paths/to/files` to identify type errors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Run `pnpm run check-types:src` or `pnpm run check-types:src paths/to/files` to identify type errors
1. Run `pnpm run check-types:src` to check entire project or `pnpm run check-types:src paths/to/files` for specific file to identify type errors

Steps:

1. Run `pnpm run check-types:src` or `pnpm run check-types:src paths/to/files` to identify type errors
2. Analyze the errors and fix them systematically
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Analyze the errors and fix them systematically
2. Analyze the errors and fix them systematically, DO NOT use `as any`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants