Conversation
🦋 Changeset detectedLatest commit: 1e15a75 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
This PR fixes broken question mark icons in the Product Type variant attributes view and Channel Allocation Strategy component by standardizing their styling to match the codebase's icon usage patterns.
- Changed CSS properties from SVG-specific (
fill,fillOpacity) to standard CSS (color,opacity) for styling the CircleQuestionMark icons - Added explicit size and strokeWidth props to CircleQuestionMark components to ensure proper rendering
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/productTypes/components/ProductTypeVariantAttributes/ProductTypeVariantAttributes.tsx |
Updated CircleQuestionMark icon with explicit size and strokeWidth props, and converted CSS properties from fill/fillOpacity to color/opacity |
src/channels/components/ChannelAllocationStrategy/styles.ts |
Converted CSS properties from fill/fillOpacity to color/opacity for tooltip icon styling |
src/channels/components/ChannelAllocationStrategy/ChannelAllocationStrategy.tsx |
Added iconSize and iconStrokeWidthBySize import and applied them to CircleQuestionMark icon |
.changeset/kind-mugs-burn.md |
Added changeset documenting the bug fix as a patch release |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6238 +/- ##
=======================================
Coverage 40.96% 40.96%
=======================================
Files 2432 2432
Lines 40957 40957
Branches 9076 9076
=======================================
Hits 16779 16779
Misses 24150 24150
Partials 28 28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Problem