Skip to content

Fix question mark icons#6238

Merged
mirekm merged 3 commits intomainfrom
fix-question-mark-icons
Dec 19, 2025
Merged

Fix question mark icons#6238
mirekm merged 3 commits intomainfrom
fix-question-mark-icons

Conversation

@mirekm
Copy link
Member

@mirekm mirekm commented Dec 19, 2025

Problem

image

Copilot AI review requested due to automatic review settings December 19, 2025 11:41
@mirekm mirekm requested a review from a team as a code owner December 19, 2025 11:41
@mirekm mirekm requested review from Droniu and witoszekdev December 19, 2025 11:41
@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2025

🦋 Changeset detected

Latest commit: 1e15a75

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes broken question mark icons in the Product Type variant attributes view and Channel Allocation Strategy component by standardizing their styling to match the codebase's icon usage patterns.

  • Changed CSS properties from SVG-specific (fill, fillOpacity) to standard CSS (color, opacity) for styling the CircleQuestionMark icons
  • Added explicit size and strokeWidth props to CircleQuestionMark components to ensure proper rendering

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/productTypes/components/ProductTypeVariantAttributes/ProductTypeVariantAttributes.tsx Updated CircleQuestionMark icon with explicit size and strokeWidth props, and converted CSS properties from fill/fillOpacity to color/opacity
src/channels/components/ChannelAllocationStrategy/styles.ts Converted CSS properties from fill/fillOpacity to color/opacity for tooltip icon styling
src/channels/components/ChannelAllocationStrategy/ChannelAllocationStrategy.tsx Added iconSize and iconStrokeWidthBySize import and applied them to CircleQuestionMark icon
.changeset/kind-mugs-burn.md Added changeset documenting the bug fix as a patch release

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 40.96%. Comparing base (6f4f0ff) to head (1e15a75).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...els/components/ChannelAllocationStrategy/styles.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6238   +/-   ##
=======================================
  Coverage   40.96%   40.96%           
=======================================
  Files        2432     2432           
  Lines       40957    40957           
  Branches     9076     9076           
=======================================
  Hits        16779    16779           
  Misses      24150    24150           
  Partials       28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mirekm mirekm merged commit 2b2311e into main Dec 19, 2025
13 of 14 checks passed
@mirekm mirekm deleted the fix-question-mark-icons branch December 19, 2025 11:54
This was referenced Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants