mounts for translations forms by lkostrowski · Pull Request #6239 · saleor/saleor-dashboard

lkostrowski · 2025-12-19T11:44:28Z

Scope of the change

I confirm I added ripples for changes (see src/ripples) or my feature doesn't contain any user-facing changes
I used analytics "trackEvent" for important events

changeset-bot · 2025-12-19T11:44:32Z

⚠️ No Changeset found

Latest commit: e9c25b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2025-12-19T11:47:24Z

Differences Found

✅ No packages or licenses were added.

Summary

Expand

License Name	Package Count	Packages
0BSD	1	Packages tslib
CC0-1.0	1	Packages type-fest
MIT/X11	1	Packages nub
MPL-1.1	1	Packages harmony-reflect
MPL-2.0	1	Packages dompurify
Public Domain	1	Packages jsonify
Python-2.0	1	Packages argparse
WTFPL	1	Packages utf8-byte-length
<<missing>>	2	Packages busboy streamsearch
CC-BY-4.0	2	Packages @saleor/macaw-ui caniuse-lite
SEE LICENSE IN LICENSE	2	Packages posthog-js spawndamnit
BlueOak-1.0.0	4	Packages glob lru-cache minimatch path-scurry
BSD-2-Clause	23	Packages browser-process-hrtime css-select css-what domelementtype domhandler domutils dotenv dotenv-expand entities escodegen eslint-scope espree esprima esrecurse estraverse esutils nth-check regjsparser stringify-object terser And 3 more...
BSD-3-Clause	42	Packages @saleor/app-sdk @sentry/cli @sentry/cli-darwin @sentry/cli-linux-arm @sentry/cli-linux-arm64 @sentry/cli-linux-i686 @sentry/cli-linux-x64 @sentry/cli-win32-arm64 @sentry/cli-win32-i686 @sentry/cli-win32-x64 @sinonjs/commons @sinonjs/fake-timers abab asn1js babel-plugin-istanbul chroma-js dataloader diff esquery exenv And 22 more...
ISC	47	Packages @istanbuljs/load-nyc-config anymatch boolbase cli-width cliui electron-to-chromium fastq flatted fs.realpath get-caller-file get-own-enumerable-property-symbols glob glob-parent graceful-fs inflight inherits ini isexe knip lru-cache And 27 more...
Apache-2.0	54	Packages @editorjs/editorjs @eslint/config-array @eslint/config-helpers @eslint/core @eslint/object-schema @eslint/plugin-kit @humanfs/core @humanfs/node @humanwhocodes/module-importer @humanwhocodes/retry @opentelemetry/api @opentelemetry/semantic-conventions @playwright/test @pollyjs/adapter @pollyjs/core @pollyjs/persister @pollyjs/utils @swc/core @swc/core-darwin-arm64 @swc/core-darwin-x64 And 34 more...
MIT	1293	Packages @adobe/css-tools @apollo/client @ardatan/relay-compiler @ardatan/sync-fetch @babel/code-frame @babel/compat-data @babel/core @babel/generator @babel/helper-annotate-as-pure @babel/helper-compilation-targets @babel/helper-create-class-features-plugin @babel/helper-globals @babel/helper-member-expression-to-functions @babel/helper-module-imports @babel/helper-module-transforms @babel/helper-optimise-call-expression @babel/helper-plugin-utils @babel/helper-replace-supers @babel/helper-skip-transparent-expression-wrappers @babel/helper-string-parser And 1273 more...

Copilot

Pull request overview

This PR adds app extension form mount support for the category translations page, enabling external apps to interact with translation form data through the app extension framework.

Adds form state emission to the category translation page using the app extension context
Updates the @saleor/app-sdk package to a pre-release version to support new form payload types
Implements data flow from the translation form to mounted app extensions

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 8 comments.

File	Description
src/translations/components/TranslationsCategoriesPage/TranslationsCategoriesPage.tsx	Adds useEffect hook to emit category translation form data to app extensions, including field values for category name, description, and SEO fields
package.json	Updates @saleor/app-sdk to pre-release version 0.0.0-pr-20251218133314

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-19T11:47:53Z

src/translations/components/TranslationsCategoriesPage/TranslationsCategoriesPage.tsx

+              currentValue: "todo",
+              originalValue: data.category.name,
+            },
+            categoryDescription: {
+              type: "editorjs",
+              fieldName: "categoryDescription",
+              translatedValue: data.translation.description,
+              currentValue: "todo",
+              originalValue: data.category.description,
+            },
+            seoName: {
+              type: "short-text",
+              fieldName: "seoName",
+              translatedValue: data.translation.seoTitle,
+              currentValue: "todo",
+              originalValue: data.category.seoTitle,
+            },
+            seoDescription: {
+              type: "short-text",
+              fieldName: "seoDescription",
+              translatedValue: data.translation.seoDescription,
+              currentValue: "todo",


The currentValue is hardcoded as "todo" which is a placeholder. This should contain the actual current value of the field being edited, similar to how the TranslationsProductsPage uses cachedProductSeoName and other cached values to track changes.

Suggested change

currentValue: "todo",

originalValue: data.category.name,

},

categoryDescription: {

type: "editorjs",

fieldName: "categoryDescription",

translatedValue: data.translation.description,

currentValue: "todo",

originalValue: data.category.description,

},

seoName: {

type: "short-text",

fieldName: "seoName",

translatedValue: data.translation.seoTitle,

currentValue: "todo",

originalValue: data.category.seoTitle,

},

seoDescription: {

type: "short-text",

fieldName: "seoDescription",

translatedValue: data.translation.seoDescription,

currentValue: "todo",

currentValue: data.translation.name,

originalValue: data.category.name,

},

categoryDescription: {

type: "editorjs",

fieldName: "categoryDescription",

translatedValue: data.translation.description,

currentValue: data.translation.description,

originalValue: data.category.description,

},

seoName: {

type: "short-text",

fieldName: "seoName",

translatedValue: data.translation.seoTitle,

currentValue: data.translation.seoTitle,

originalValue: data.category.seoTitle,

},

seoDescription: {

type: "short-text",

fieldName: "seoDescription",

translatedValue: data.translation.seoDescription,

currentValue: data.translation.seoDescription,

Copilot · 2025-12-19T11:47:54Z

src/translations/components/TranslationsCategoriesPage/TranslationsCategoriesPage.tsx

+              currentValue: "todo",
+              originalValue: data.category.name,
+            },
+            categoryDescription: {
+              type: "editorjs",
+              fieldName: "categoryDescription",
+              translatedValue: data.translation.description,
+              currentValue: "todo",
+              originalValue: data.category.description,
+            },
+            seoName: {
+              type: "short-text",
+              fieldName: "seoName",
+              translatedValue: data.translation.seoTitle,
+              currentValue: "todo",
+              originalValue: data.category.seoTitle,
+            },
+            seoDescription: {
+              type: "short-text",
+              fieldName: "seoDescription",
+              translatedValue: data.translation.seoDescription,
+              currentValue: "todo",


The currentValue is hardcoded as "todo" which is a placeholder. This should contain the actual current value of the field being edited, similar to how the TranslationsProductsPage uses cachedProductSeoDescription and other cached values to track changes.

Suggested change

currentValue: "todo",

originalValue: data.category.name,

},

categoryDescription: {

type: "editorjs",

fieldName: "categoryDescription",

translatedValue: data.translation.description,

currentValue: "todo",

originalValue: data.category.description,

},

seoName: {

type: "short-text",

fieldName: "seoName",

translatedValue: data.translation.seoTitle,

currentValue: "todo",

originalValue: data.category.seoTitle,

},

seoDescription: {

type: "short-text",

fieldName: "seoDescription",

translatedValue: data.translation.seoDescription,

currentValue: "todo",

currentValue: data.translation?.name,

originalValue: data.category.name,

},

categoryDescription: {

type: "editorjs",

fieldName: "categoryDescription",

translatedValue: data.translation.description,

currentValue: data.translation?.description,

originalValue: data.category.description,

},

seoName: {

type: "short-text",

fieldName: "seoName",

translatedValue: data.translation.seoTitle,

currentValue: data.translation?.seoTitle,

originalValue: data.category.seoTitle,

},

seoDescription: {

type: "short-text",

fieldName: "seoDescription",

translatedValue: data.translation.seoDescription,

currentValue: data.translation?.seoDescription,

Copilot · 2025-12-19T11:47:54Z

src/translations/components/TranslationsCategoriesPage/TranslationsCategoriesPage.tsx

+        }),
+      );
+    }
+  }, [active, data?.category, data?.category?.id]);


The useEffect dependency array is incomplete. It should include languageCode, data?.translation, attachFormState, and the individual data fields being accessed (data.translation.name, data.translation.description, etc.) since these values are used within the effect. Currently, changes to these values won't trigger the effect to re-run as expected.

Suggested change

}, [active, data?.category, data?.category?.id]);

}, [

active,

attachFormState,

languageCode,

data?.category?.id,

data?.category?.name,

data?.category?.description,

data?.category?.seoTitle,

data?.category?.seoDescription,

data?.translation?.name,

data?.translation?.description,

data?.translation?.seoTitle,

data?.translation?.seoDescription,

]);

Copilot · 2025-12-19T11:47:54Z

package.json

    "@graphql-eslint/eslint-plugin": "^4.4.0",
    "@playwright/test": "1.56.1",
-    "@saleor/app-sdk": "1.5.0",
+    "@saleor/app-sdk": "0.0.0-pr-20251218133314",


The version "0.0.0-pr-20251218133314" appears to be a pre-release or PR-specific version. This should not be committed to the main branch and should instead use a stable, published version of the package.

Suggested change

"@saleor/app-sdk": "0.0.0-pr-20251218133314",

"@saleor/app-sdk": "^0.61.0",

Copilot · 2025-12-19T11:47:55Z

src/translations/components/TranslationsCategoriesPage/TranslationsCategoriesPage.tsx

  languageEntityUrl,
  TranslatableEntities,
 } from "@dashboard/translations/urls";
+import { DashboardEventFactory } from "@saleor/app-sdk/app-bridge";


This import is unnecessary since attachFormState should receive the payload directly without wrapping it in DashboardEventFactory.createFormEvent. The createFormEvent transformation is handled internally by the framework.

Copilot · 2025-12-19T11:47:55Z

src/translations/components/TranslationsCategoriesPage/TranslationsCategoriesPage.tsx

+              currentValue: "todo",
+              originalValue: data.category.name,
+            },
+            categoryDescription: {
+              type: "editorjs",
+              fieldName: "categoryDescription",
+              translatedValue: data.translation.description,
+              currentValue: "todo",
+              originalValue: data.category.description,
+            },
+            seoName: {
+              type: "short-text",
+              fieldName: "seoName",
+              translatedValue: data.translation.seoTitle,
+              currentValue: "todo",
+              originalValue: data.category.seoTitle,
+            },
+            seoDescription: {
+              type: "short-text",
+              fieldName: "seoDescription",
+              translatedValue: data.translation.seoDescription,
+              currentValue: "todo",


The currentValue is hardcoded as "todo" which is a placeholder. This should contain the actual current value of the field being edited, similar to how the TranslationsProductsPage uses cachedProductName and other cached values to track changes.

Suggested change

currentValue: "todo",

originalValue: data.category.name,

},

categoryDescription: {

type: "editorjs",

fieldName: "categoryDescription",

translatedValue: data.translation.description,

currentValue: "todo",

originalValue: data.category.description,

},

seoName: {

type: "short-text",

fieldName: "seoName",

translatedValue: data.translation.seoTitle,

currentValue: "todo",

originalValue: data.category.seoTitle,

},

seoDescription: {

type: "short-text",

fieldName: "seoDescription",

translatedValue: data.translation.seoDescription,

currentValue: "todo",

currentValue: data.translation.name,

originalValue: data.category.name,

},

categoryDescription: {

type: "editorjs",

fieldName: "categoryDescription",

translatedValue: data.translation.description,

currentValue: data.translation.description,

originalValue: data.category.description,

},

seoName: {

type: "short-text",

fieldName: "seoName",

translatedValue: data.translation.seoTitle,

currentValue: data.translation.seoTitle,

originalValue: data.category.seoTitle,

},

seoDescription: {

type: "short-text",

fieldName: "seoDescription",

translatedValue: data.translation.seoDescription,

currentValue: data.translation.seoDescription,

Copilot · 2025-12-19T11:47:56Z

src/translations/components/TranslationsCategoriesPage/TranslationsCategoriesPage.tsx

+      attachFormState(
+        // @ts-ignore - wtf with types
+        DashboardEventFactory.createFormEvent({
+          form: "category-translate",
+          categoryId: data.category.id,
+          translationLanguage: languageCode,
+          fields: {
+            categoryName: {
+              type: "short-text",
+              fieldName: "categoryName",
+              translatedValue: data.translation.name,
+              currentValue: "todo",
+              originalValue: data.category.name,
+            },
+            categoryDescription: {
+              type: "editorjs",
+              fieldName: "categoryDescription",
+              translatedValue: data.translation.description,
+              currentValue: "todo",
+              originalValue: data.category.description,
+            },
+            seoName: {
+              type: "short-text",
+              fieldName: "seoName",
+              translatedValue: data.translation.seoTitle,
+              currentValue: "todo",
+              originalValue: data.category.seoTitle,
+            },
+            seoDescription: {
+              type: "short-text",
+              fieldName: "seoDescription",
+              translatedValue: data.translation.seoDescription,
+              currentValue: "todo",
+              originalValue: data.category.seoDescription,
+            },
+          },
+        }),
+      );


The DashboardEventFactory.createFormEvent is being used incorrectly. Based on the codebase patterns (ProductUpdatePage and TranslationsProductsPage), attachFormState should receive the payload directly without wrapping it in DashboardEventFactory.createFormEvent. The createFormEvent is applied internally by the hook when posting to the extension.

Copilot · 2025-12-19T11:47:56Z

src/translations/components/TranslationsCategoriesPage/TranslationsCategoriesPage.tsx

+              currentValue: "todo",
+              originalValue: data.category.name,
+            },
+            categoryDescription: {
+              type: "editorjs",
+              fieldName: "categoryDescription",
+              translatedValue: data.translation.description,
+              currentValue: "todo",
+              originalValue: data.category.description,
+            },
+            seoName: {
+              type: "short-text",
+              fieldName: "seoName",
+              translatedValue: data.translation.seoTitle,
+              currentValue: "todo",
+              originalValue: data.category.seoTitle,
+            },
+            seoDescription: {
+              type: "short-text",
+              fieldName: "seoDescription",
+              translatedValue: data.translation.seoDescription,
+              currentValue: "todo",


The currentValue is hardcoded as "todo" which is a placeholder. This should contain the actual current value of the field being edited, similar to how the TranslationsProductsPage uses cachedProductDescription and other cached values to track changes.

Suggested change

currentValue: "todo",

originalValue: data.category.name,

},

categoryDescription: {

type: "editorjs",

fieldName: "categoryDescription",

translatedValue: data.translation.description,

currentValue: "todo",

originalValue: data.category.description,

},

seoName: {

type: "short-text",

fieldName: "seoName",

translatedValue: data.translation.seoTitle,

currentValue: "todo",

originalValue: data.category.seoTitle,

},

seoDescription: {

type: "short-text",

fieldName: "seoDescription",

translatedValue: data.translation.seoDescription,

currentValue: "todo",

currentValue: data.translation.name,

originalValue: data.category.name,

},

categoryDescription: {

type: "editorjs",

fieldName: "categoryDescription",

translatedValue: data.translation.description,

currentValue: data.translation.description,

originalValue: data.category.description,

},

seoName: {

type: "short-text",

fieldName: "seoName",

translatedValue: data.translation.seoTitle,

currentValue: data.translation.seoTitle,

originalValue: data.category.seoTitle,

},

seoDescription: {

type: "short-text",

fieldName: "seoDescription",

translatedValue: data.translation.seoDescription,

currentValue: data.translation.seoDescription,

codecov · 2025-12-19T11:48:16Z

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.96%. Comparing base (f7ef997) to head (e9c25b3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...tionsCategoriesPage/TranslationsCategoriesPage.tsx	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6239      +/-   ##
==========================================
- Coverage   40.97%   40.96%   -0.02%     
==========================================
  Files        2432     2432              
  Lines       40949    40961      +12     
  Branches     9409     9415       +6     
==========================================
  Hits        16779    16779              
- Misses      22932    22943      +11     
- Partials     1238     1239       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mounts for translations forms

e9c25b3

Copilot AI review requested due to automatic review settings December 19, 2025 11:44

Copilot started reviewing on behalf of lkostrowski December 19, 2025 11:44 View session

Copilot AI reviewed Dec 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

mounts for translations forms#6239

mounts for translations forms#6239
lkostrowski wants to merge 1 commit intomainfrom
translations-mounts

lkostrowski commented Dec 19, 2025

Uh oh!

changeset-bot bot commented Dec 19, 2025

Uh oh!

github-actions bot commented Dec 19, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 19, 2025

Uh oh!

Copilot AI Dec 19, 2025

Uh oh!

Copilot AI Dec 19, 2025

Uh oh!

Copilot AI Dec 19, 2025

Uh oh!

Copilot AI Dec 19, 2025

Uh oh!

Copilot AI Dec 19, 2025

Uh oh!

Copilot AI Dec 19, 2025

Uh oh!

Copilot AI Dec 19, 2025

Uh oh!

codecov bot commented Dec 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

-  }, [active, data?.category, data?.category?.id]);
+  }, [
+    active,
+    attachFormState,
+    languageCode,
+    data?.category?.id,
+    data?.category?.name,
+    data?.category?.description,
+    data?.category?.seoTitle,
+    data?.category?.seoDescription,
+    data?.translation?.name,
+    data?.translation?.description,
+    data?.translation?.seoTitle,
+    data?.translation?.seoDescription,
+  ]);

	"@saleor/app-sdk": "0.0.0-pr-20251218133314",
	"@saleor/app-sdk": "^0.61.0",

Comments

Conversation

lkostrowski commented Dec 19, 2025

Scope of the change

Uh oh!

changeset-bot bot commented Dec 19, 2025

⚠️ No Changeset found

Uh oh!

github-actions bot commented Dec 19, 2025

Differences Found

Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 19, 2025

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant