Fix .github/workflows not using it's own pnpm-lockfile.yaml#6275
Fix .github/workflows not using it's own pnpm-lockfile.yaml#6275witoszekdev merged 3 commits intomainfrom
Conversation
|
witoszekdev
added
skip changeset
There was a problem hiding this comment.
Pull request overview
This pull request reorganizes the project's pnpm workspace structure to create independent package management for the .github/workflows directory. The changes separate the GitHub Actions workflow dependencies from the root project workspace, preventing dependency conflicts and ensuring workflows use their own dedicated lockfile.
Changes:
- Configured root workspace with
recursiveInstall: falseandsharedWorkspaceLockfile: falseto enable independent workspaces - Created a separate pnpm workspace in
.github/workflowswith its own lockfile and configuration - Migrated from npm (package-lock.json) to pnpm (pnpm-lock.yaml) for workflow dependencies and updated Node engine requirement from >=14 to >=20
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Added workspace isolation settings to prevent sharing lockfiles between root and subdirectories |
| .github/workflows/pnpm-workspace.yaml | Created new workspace configuration to make workflows directory an independent pnpm project |
| .github/workflows/pnpm-lock.yaml | Added new pnpm lockfile with ~1000 lines defining workflow dependencies |
| .github/workflows/package.json | Updated Node engine requirement to >=20, added packageManager field, and reorganized field order |
| .github/workflows/package-lock.json | Removed npm lockfile (replaced by pnpm-lock.yaml) |
| .github/workflows/.nvmrc | Added Node version file specifying version 22 |
Files not reviewed (2)
- .github/workflows/package-lock.json: Language not supported
- .github/workflows/pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| trustPolicy: no-downgrade | ||
|
|
||
| packages: [] |
There was a problem hiding this comment.
The PR title contains a grammatical error. "it's" should be "its" (possessive form, not contraction). The title should read: "Fix .github/workflows not using its own pnpm-lockfile.yaml"
| packages: [] | |
| packages: | |
| - "src" | |
| - ".github/workflows" |
| @@ -0,0 +1 @@ | |||
| 22 | |||
There was a problem hiding this comment.
The .nvmrc file specifies Node version 22, but the package.json requires Node >=20. While Node 22 satisfies the >=20 requirement, this creates a potential inconsistency. If the project requires Node 20 as the minimum, the .nvmrc should specify 20, or if Node 22 is actually required, the package.json engines field should be updated to reflect this (e.g., "node": ">=22"). Consider aligning these values to avoid confusion about which Node version is actually required.
| 22 | |
| 20 |
Differences Found✅ No packages or licenses were added. SummaryExpand
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6275 +/- ##
=========================================
Coverage 42.53% 42.53%
=========================================
Files 2486 2486
Lines 42955 42955
Branches 10109 9694 -415
=========================================
Hits 18271 18271
- Misses 23386 24649 +1263
+ Partials 1298 35 -1263 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
witoszekdev
added
the
test deployment
|
e2e tests are failing but that's not due to the setup (like previously) but due to missing element (either slow env for PR tests, or we need to fix something in tests) |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- .github/workflows/package-lock.json: Language not supported
- .github/workflows/pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }, | ||
| "packageManager": "pnpm@10.28.1", | ||
| "engines": { | ||
| "node": ">=22" |
There was a problem hiding this comment.
The engines.node field specifies ">=22" which is more permissive than the root package.json's "^20 || ^22" and could allow Node 23+ versions. This inconsistency may lead to compatibility issues. Consider aligning this with the root package.json constraint or explicitly documenting why the workflows directory needs a different Node version requirement.
| "node": ">=22" | |
| "node": "^20 || ^22" |
2 participants
Fixed e2e tests failing due to missing dependencies