Conversation
🦋 Changeset detectedLatest commit: bc08fc7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
This PR fixes failing e2e tests by enhancing mutation responses to fetch complete order details and adding missing test identifiers for UI elements.
Changes:
- Updated GraphQL order line mutations to return a comprehensive
OrderLinesUpdatefragment containing all fields that can change when order lines are modified (lines, pricing, shipping, discounts) - Added
data-test-typeattribute to Toast component anddata-testidto DataGrid canvas for e2e test targeting - Updated Playwright selectors to use correct test identifiers
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/orders/mutations.ts | Modified order line mutations to use OrderLinesUpdate fragment instead of minimal fields |
| src/fragments/orders.ts | Added new OrderLinesUpdate fragment to fetch comprehensive order data that changes with line mutations |
| src/graphql/types.generated.ts | Generated TypeScript types for new OrderLinesUpdate fragment |
| src/graphql/hooks.generated.ts | Generated React hooks referencing OrderLinesUpdate fragment |
| src/orders/components/OrderSummary/OrderValue.tsx | Refactored prop types to separate dynamic fields (LineUpdateFields) from static fields (StaticFields) |
| src/orders/components/OrderSummary/OrderValue.test.tsx | Updated test props to include new required fields from OrderLinesUpdate fragment |
| src/orders/components/OrderSummary/OrderSummary.tsx | Passed additional props (isShippingRequired, shippingMethods, shippingMethod) to OrderValue component |
| src/components/notifications/Toast.tsx | Added data-test-type attribute for e2e test targeting |
| src/components/Datagrid/Datagrid.tsx | Added data-testid="data-grid-canvas" for e2e test targeting |
| playwright/pages/productPage.ts | Updated selector from product-available-in-channels-text to availability-card |
| playwright/data/copy.ts | Updated expected text from "In 1 out of" to "In 1 of" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6292 +/- ##
==========================================
- Coverage 42.58% 42.58% -0.01%
==========================================
Files 2497 2497
Lines 43372 43373 +1
Branches 10231 9850 -381
==========================================
Hits 18470 18470
- Misses 24865 24866 +1
Partials 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Differences Found✅ No packages or licenses were added. SummaryExpand
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 27 out of 27 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| return ( | ||
| <Box | ||
| data-test-type={type} |
There was a problem hiding this comment.
The attribute name data-test-type is inconsistent with the naming convention used throughout the codebase. All other test identifiers use data-test-id. Consider using data-test-id="toast" and differentiating by the type value, or use a more specific name like data-test-id={toast-${type}} to maintain consistency with the rest of the codebase.
Fixed failing e2e tests:
data-testidfor notifications and DataGridawait