Skip to content

Comments

Add slack notifications for docker build failure#6316

Merged
witoszekdev merged 2 commits intomainfrom
add-notify-slack-docker-build
Feb 5, 2026
Merged

Add slack notifications for docker build failure#6316
witoszekdev merged 2 commits intomainfrom
add-notify-slack-docker-build

Conversation

@witoszekdev
Copy link
Member

@witoszekdev witoszekdev commented Feb 4, 2026

Added notifications to internal #dashboard-alerts channel on Slack to get notified about failures in Docker images build, creating new releases

Copilot AI review requested due to automatic review settings February 4, 2026 13:26
@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2026

⚠️ No Changeset found

Latest commit: f1251fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@witoszekdev witoszekdev added skip changeset Use if your changes doesn't need entry in changelog labels Feb 4, 2026
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.59%. Comparing base (160511f) to head (f1251fb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6316    +/-   ##
========================================
  Coverage   42.59%   42.59%            
========================================
  Files        2497     2497            
  Lines       43401    43401            
  Branches    10232     9851   -381     
========================================
  Hits        18485    18485            
  Misses      24879    24879            
  Partials       37       37            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Docker image build to include additional config for pnpm, cleans up Dockerfile style/warnings, and introduces Slack notifications on failure for key release and container publish workflows.

Changes:

  • Update Dockerfile to copy pnpm workspace/.npmrc files, normalize ENV syntax, and add OCI metadata labels (including commit and version).
  • Enhance publish-containers.yml to pass commit/version build args into the image and send a Slack notification when the image build fails.
  • Add Slack failure notifications to the new-current-patch-release.yml and create-draft-release.yml workflows via 1Password-managed webhook secrets.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
Dockerfile Adjusts pnpm install context, environment variable declarations, and adds OCI labels using build args for commit and version.
.github/workflows/publish-containers.yml Extends container publish workflow with commit/version build args and a Slack failure notification job using 1Password secrets.
.github/workflows/new-current-patch-release.yml Adds a Slack notification job that triggers when recreating the current patch release branch fails.
.github/workflows/create-draft-release.yml Adds a Slack notification job that triggers when creating a draft release fails.

Comment on lines 32 to 36
ENV API_URL="${API_URL:-http://localhost:8000/graphql/}"
ENV APP_MOUNT_URI="${APP_MOUNT_URI:-/dashboard/}"
ENV APPS_MARKETPLACE_API_URL="${APPS_MARKETPLACE_API_URL:-https://apps.saleor.io/api/v2/saleor-apps}"
ENV EXTENSIONS_API_URL="${EXTENSIONS_API_URL:-https://apps.saleor.io/api/v1/extensions}"
ENV APPS_TUNNEL_URL_KEYWORDS="${APPS_TUNNEL_URL_KEYWORDS}"
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of shell-style parameter expansion in these ENV instructions (e.g. ${API_URL:-http://localhost:8000/graphql/}) will not behave as intended in a Dockerfile: Docker only supports simple ${VAR}/$VAR expansion and does not interpret :- defaults, so the resulting environment values will not fall back to the provided defaults when the build args are unset. To ensure sensible defaults, consider either assigning explicit default values in the ARG declarations and referencing them directly, or setting ENV values without :- and relying on Docker build arguments or runtime environment variables to override them.

Copilot uses AI. Check for mistakes.
@witoszekdev witoszekdev force-pushed the add-notify-slack-docker-build branch from 6ba442b to 681eb9e Compare February 4, 2026 13:34
@witoszekdev witoszekdev marked this pull request as ready for review February 4, 2026 13:35
@witoszekdev witoszekdev requested a review from a team as a code owner February 4, 2026 13:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@witoszekdev witoszekdev enabled auto-merge (squash) February 5, 2026 13:12
@witoszekdev witoszekdev merged commit 112f309 into main Feb 5, 2026
12 checks passed
@witoszekdev witoszekdev deleted the add-notify-slack-docker-build branch February 5, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants