Skip to content

Comments

ENG-1259 - stop tagging non-latest images as latest#6319

Merged
stmpn merged 2 commits intomainfrom
ENG-1259
Feb 6, 2026
Merged

ENG-1259 - stop tagging non-latest images as latest#6319
stmpn merged 2 commits intomainfrom
ENG-1259

Conversation

@stmpn
Copy link
Member

@stmpn stmpn commented Feb 6, 2026

No description provided.

@stmpn stmpn requested a review from a team as a code owner February 6, 2026 10:25
@stmpn stmpn requested review from NyanKiyoshi, Copilot, lkostrowski and witoszekdev and removed request for Copilot, lkostrowski and witoszekdev February 6, 2026 10:25
@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2026

⚠️ No Changeset found

Latest commit: e5ebf2e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@stmpn stmpn requested a review from magul February 6, 2026 10:25
@stmpn stmpn added the skip changeset Use if your changes doesn't need entry in changelog label Feb 6, 2026
@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.59%. Comparing base (112f309) to head (e5ebf2e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #6319     +/-   ##
=========================================
  Coverage   42.59%   42.59%             
=========================================
  Files        2497     2497             
  Lines       43401    43401             
  Branches    10232     9851    -381     
=========================================
  Hits        18485    18485             
- Misses      23590    24879   +1289     
+ Partials     1326       37   -1289     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI review requested due to automatic review settings February 6, 2026 11:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modifies the container publishing workflow to prevent non-latest releases from being tagged with the "latest" Docker image tag. Previously, every published release would automatically receive the "latest" tag. The PR introduces logic to compare the current tag being published against the repository's latest release to determine if it should receive the "latest" tag.

Changes:

  • Added a new step to check if the current tag is the actual latest version by comparing with the repository's latest release using version sorting
  • Configured Docker metadata action to disable automatic "latest" tagging and conditionally apply it based on the version check

Copy link
Member

@witoszekdev witoszekdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

if i understand correctly - this should fix 3.21.19 marked as latest once we release patch for 3.22.*?

@stmpn
Copy link
Member Author

stmpn commented Feb 6, 2026

lgtm

if i understand correctly - this should fix 3.21.19 marked as latest once we release patch for 3.22.*?

Yes, once we release new latest version the situation will correct itself and it should work properly from now on

@stmpn stmpn merged commit 2417a3e into main Feb 6, 2026
20 checks passed
@stmpn stmpn deleted the ENG-1259 branch February 6, 2026 15:39
@NyanKiyoshi NyanKiyoshi changed the title ENG-1159 - stop tagging non-latest images as latest ENG-1259 - stop tagging non-latest images as latest Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants