Skip to content

Comments

Remove unused files, apply lint#6358

Open
lkostrowski wants to merge 3 commits intomainfrom
knip-unused-files
Open

Remove unused files, apply lint#6358
lkostrowski wants to merge 3 commits intomainfrom
knip-unused-files

Conversation

@lkostrowski
Copy link
Member

  • Run knip, removed files marked as unused → all pass
  • Update knip to not report mutations/queries
  • Auto-fixed some eslint issues

Copilot AI review requested due to automatic review settings February 23, 2026 21:39
@lkostrowski lkostrowski requested a review from a team as a code owner February 23, 2026 21:39
@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2026

⚠️ No Changeset found

Latest commit: 70a4c49

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lkostrowski lkostrowski added the skip changeset Use if your changes doesn't need entry in changelog label Feb 23, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs cleanup by removing unused files identified by the knip tool and applying automated eslint fixes for type imports. The changes focus on eliminating dead code while ensuring no breaking changes to the codebase.

Changes:

  • Removed unused component files and barrel exports (index.ts files) from orders, icons, sidebar, and other components
  • Updated knip configuration to use wildcard patterns for queries and mutations files
  • Applied eslint auto-fixes to add type keyword to type-only imports across Playwright test files

Reviewed changes

Copilot reviewed 67 out of 67 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/orders/components/OrderUsedGiftCards/index.ts Removed barrel export; component imported directly from .tsx file
src/orders/components/OrderTransactionsSection/index.ts Removed barrel export; component imported directly from .tsx file
src/orders/components/OrderSummaryCard/*.ts Removed entire unused OrderSummaryCard component and related files
src/orders/components/OrderPaymentSummaryCard/*.ts Removed unused files; OrderPaymentStatusPill subcomponent still exists and is used
src/orders/components/OrderPaymentDialog/*.tsx Removed entire unused OrderPaymentDialog component
src/icons/*.tsx Removed unused icon components (Edit, ArrowDropdown)
src/components/Sidebar/menu/EnvironmentLink.tsx Removed unused component
src/components/OverflowTooltip/*.tsx Removed entire unused OverflowTooltip component
src/components/ModalFilters/ModalFiltersProvider.tsx Removed unused provider component
src/components/ListItemLink/*.tsx Removed entire unused ListItemLink component
src/components/Combobox/hooks/useComboboxEmptyOption.ts Removed unused hook
src/attributes/components/AttributeValues/index.ts Removed barrel export; component imported directly from .tsx file
.knip.json Updated patterns from queries.ts to queries*.ts and mutations.ts to mutations*.ts for better coverage
playwright/**/*.ts Applied eslint auto-fix to add type keyword to type-only imports (Page, APIRequestContext, etc.)

@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.85%. Comparing base (fca0cbf) to head (70a4c49).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6358      +/-   ##
==========================================
+ Coverage   42.71%   42.85%   +0.13%     
==========================================
  Files        2534     2516      -18     
  Lines       44006    43864     -142     
  Branches    10417    10413       -4     
==========================================
  Hits        18799    18799              
+ Misses      23868    23737     -131     
+ Partials     1339     1328      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

witoszekdev
witoszekdev previously approved these changes Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants