Skip to content

Comments

fix slack notification workflow#6359

Merged
lkostrowski merged 2 commits intomainfrom
fix-slack-notify
Feb 24, 2026
Merged

fix slack notification workflow#6359
lkostrowski merged 2 commits intomainfrom
fix-slack-notify

Conversation

@lkostrowski
Copy link
Member

mention on slack only if workflow fails

Copilot AI review requested due to automatic review settings February 24, 2026 09:00
@lkostrowski lkostrowski requested a review from a team as a code owner February 24, 2026 09:00
@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2026

⚠️ No Changeset found

Latest commit: e72a306

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Slack notification behavior in deployment workflows so the Slack mention is only applied when the workflow fails, matching the stated intent for reduced noise during successful runs.

Changes:

  • Add mention_on: failure to the notify-slack reusable workflow invocation for staging/release deployments
  • Add mention_on: failure to the notify-slack invocation for master-staging deployments
  • Add mention_on: failure to the notify-slack invocation for cloud deployments

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/deploy-staging-and-prepare-release.yaml Configure Slack notification mentions to trigger only on failure for staging + prepare-release flow.
.github/workflows/deploy-master-staging.yaml Configure Slack notification mentions to trigger only on failure for master-staging deployments.
.github/workflows/deploy-cloud.yaml Configure Slack notification mentions to trigger only on failure for cloud deployments.

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.67%. Comparing base (8c5f075) to head (e72a306).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6359   +/-   ##
=======================================
  Coverage   42.67%   42.67%           
=======================================
  Files        2517     2517           
  Lines       43696    43696           
  Branches    10341    10380   +39     
=======================================
  Hits        18647    18647           
  Misses      23719    23719           
  Partials     1330     1330           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lkostrowski lkostrowski added the skip changeset Use if your changes doesn't need entry in changelog label Feb 24, 2026
@lkostrowski lkostrowski enabled auto-merge (squash) February 24, 2026 10:11
@lkostrowski lkostrowski disabled auto-merge February 24, 2026 10:14
@lkostrowski lkostrowski enabled auto-merge (squash) February 24, 2026 10:14
@lkostrowski lkostrowski merged commit 7ea2858 into main Feb 24, 2026
14 checks passed
@lkostrowski lkostrowski deleted the fix-slack-notify branch February 24, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants