Conversation
🦋 Changeset detectedLatest commit: 9094c0a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6363 +/- ##
==========================================
- Coverage 42.72% 42.72% -0.01%
==========================================
Files 2534 2536 +2
Lines 44009 44022 +13
Branches 10027 10457 +430
==========================================
+ Hits 18802 18807 +5
+ Misses 25167 23876 -1291
- Partials 40 1339 +1299 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This pull request adds a ripple notification to inform users about the new app problems visibility feature in the installed extensions page.
Changes:
- Added a new ripple definition for app problems feature visibility
- Created comprehensive Storybook stories for the Ripple component
- Integrated the ripple into the InstalledExtensions view to appear next to the ProblemsHeaderBadge
- Updated auto-generated GraphQL type files with documentation comments for CountryCode enum
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/extensions/ripples/appProblems.tsx | Defines the app problems ripple with content describing the feature |
| src/ripples/allRipples.ts | Registers the new app problems ripple in the central ripples registry |
| src/extensions/views/InstalledExtensions/InstalledExtensions.tsx | Integrates the ripple component to appear when app problems are present |
| src/ripples/components/Ripple.stories.tsx | Adds Storybook stories documenting different ripple configurations |
| src/graphql/types.generated.ts | Auto-generated file with documentation comments for CountryCode enum values |
| src/graphql/fabbricaTypes.generated.ts | Auto-generated file with documentation comments for CountryCode enum values |
| .changeset/long-fish-land.md | Documents the change for release notes |
| global: | ||
| "App problems are now visible in the installed extensions page. When an app has issues, you will see a badge indicating the number of problems and their severity.", | ||
| }, | ||
| dateAdded: new Date(2026, 1), |
There was a problem hiding this comment.
The dateAdded field should include a day parameter for consistency and clarity. Most other ripples in the codebase specify the full date with year, month, and day (e.g., new Date(2026, 0, 29) or new Date("2026-01-27")). While new Date(2026, 1) is valid and defaults to the first day of the month, explicitly specifying the day makes the intended date clearer and follows the predominant pattern in the codebase.
| dateAdded: new Date(2026, 1), | |
| dateAdded: new Date(2026, 1, 1), |
| global: | ||
| "App problems are now visible in the installed extensions page. When an app has issues, you will see a badge indicating the number of problems and their severity.", | ||
| }, | ||
| dateAdded: new Date(2026, 1), |
There was a problem hiding this comment.
looks like date is not correct
There was a problem hiding this comment.
I meant that today is Feb 24th 😄
There was a problem hiding this comment.
if we take just the month though from this date then it's fine 👌🏻
2 participants
Scope of the change