Fix segment docs: diagram and event used for testing#1447
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lkostrowski
reviewed
Jan 21, 2025
Comment on lines
70
to
71
| App-->>-AppConfiguration: Fetch app configuration | ||
| AppConfiguration-->>+App: Return configuration |
Member
There was a problem hiding this comment.
I think this is a wrong abstract. Configuration is something internal to app, contrary to previous approach where metadata was something external.
I suggest to change AppConfiguration to Database and thats it - configuration is indeed fetched from DB
The details about DynamoDB can be left to "development" part
lkostrowski
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.