Skip to content

Comments

App-sdk v1 docs#1490

Merged
lkostrowski merged 8 commits intomainfrom
app-sdk-v1
Mar 20, 2025
Merged

App-sdk v1 docs#1490
lkostrowski merged 8 commits intomainfrom
app-sdk-v1

Conversation

@lkostrowski
Copy link
Member

@lkostrowski lkostrowski commented Mar 5, 2025

@vercel
Copy link

vercel bot commented Mar 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 11:10am


export default createManifestHandler({
manifestFactory({ request, appBaseUrl }) {
manifestFactory({ request, appBaseUrl, schemaVersion }) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: do we need here schemaVersion? I mean is something we recommend to do with it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to show all available options here (and there are not much). I dont have strong opinion

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: maybe it will be better to have next-api-handlers & aws-api-handlers files?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added examples. I think it's fine to add dedicated pages too. But I suggest to do this in next PRs.

I wanted this PR to contain everything required with v1:

  • Data to be up to date / accurate
  • Migration guide

Maybe in next PRs we can extend docs with additional things?

witoszekdev
witoszekdev previously approved these changes Mar 5, 2025
Copy link
Member

@witoszekdev witoszekdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we can also update our app tutorial and add links to templates for each platform (Cloudflare, Deno, etc.) I already made a PR with these changes: https://github.com/saleor/saleor-docs/pull/1437/files


app-sdk provides support for multiple platforms. To import specific platform, ensure that you are using the correct import path, for example:
- For AWS Lambda `import { SaleorAsyncWebhook } from "@saleor/app-sdk/handlers/aws-lambda";`
- For NextJS App Router `import { SaleorAsyncWebhook } from "@saleor/app-sdk/handlers/next-app-router";`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: let's add link to page where we list all available platforms

@lkostrowski lkostrowski merged commit df18ffe into main Mar 20, 2025
8 checks passed
@lkostrowski lkostrowski deleted the app-sdk-v1 branch March 20, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants