This repository was archived by the owner on May 1, 2025. It is now read-only.
Add disableTracking to StoreConfig#519
Open
hrvbernardic wants to merge 1 commit intosalesforce:masterfrom
Open
Add disableTracking to StoreConfig#519hrvbernardic wants to merge 1 commit intosalesforce:masterfrom
hrvbernardic wants to merge 1 commit intosalesforce:masterfrom
Conversation
|
|
||
| export const tick = () => new Promise(process.nextTick); | ||
|
|
||
| @StoreConfig({ name: 'disabledTrackingConfig', disableTracking: true }) |
Collaborator
Author
There was a problem hiding this comment.
Ok, so my idea was to enable using Akita in libraries for complex components. This way I could disable it by default and the application developer wouldn't see them unless he chose to through let's say component's module configuration. I suppose you want me to add storeBlacklist to devtools options? In that case i should do it by providing storeBlacklistPattern since i will be relying on storeName's prefix.
Collaborator
There was a problem hiding this comment.
Add storeBlacklist and support both strings and cb function.
Collaborator
There was a problem hiding this comment.
And add yourself to the contributors' list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently there is no way to exclude certain store from devtools tracking through store config.
Issue Number: N/A
What is the new behavior?
With new disableTracking flag it is possible to disable tracking for a certain store allowing you to use it in a library and having an option to not pollute applications devtools tracking or providing an option to turn it on when needed.
Does this PR introduce a breaking change?
Other information