Improve versions, add all clients, automate client creation. #1975
Improve versions, add all clients, automate client creation. #1975saleweaver merged 9 commits intomasterfrom
Conversation
automate adding new clients, improve documentation
automate adding new clients, improve documentation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
automate adding new clients, improve documentation
automate adding new clients, improve documentation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85afc6b98b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| _DISPATCH = True | ||
|
|
||
| _DEFAULT_VERSION = "2021-08-01" |
There was a problem hiding this comment.
With _DEFAULT_VERSION set to "2021-08-01", calling ListingsItems() (no version) dispatches to the latest implementation, but both the class docstring and the new version-dispatch tests expect the oldest implementation (2020-09-01) to be the default (see tests/api/test_versioned_clients.py ListingsItems case). This mismatch means the default behavior differs from the documented contract and will fail the new tests; callers expecting the “oldest supported” default won’t get it unless they explicitly pass a version.
Useful? React with 👍 / 👎.
| _DISPATCH = True | ||
|
|
||
| _DEFAULT_VERSION = "2021-08-01" |
There was a problem hiding this comment.
The async ListingsItems() default also points at "2021-08-01", even though the new version-dispatch tests and the class docstring describe the default as the oldest supported version (2020-09-01). This causes the async default to diverge from the documented behavior and the test expectations (tests/api/test_versioned_clients.py async ListingsItems case).
Useful? React with 👍 / 👎.
1 participant
No description provided.