Open
Conversation
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Owner
|
Hi. Thanks. Im happy to discuss merging this in, I have two concerns though:
Maybe we can release the current (non-esm) version to npm using a |
Contributor
Author
|
I'm ok with breaking ESM support but a lack of Intl.Segmenter support is a problem. Not sure what to do. |
Owner
|
@Richienb then I think I can add a legacy sub-import to fix this. eg: if imported from ES6 -> Intl.Segmenter OR
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require Node.js 16 and move to ESM
Intl.Segmenteris much more accurate than the regex was.Fixes #50, Fixes #33