[master] Fix calculation of SLS context vars when trailing dots on targetted sls/state

[meaksh]

What does this PR do?

This PR fixes a problem on the behavior of SLS context vars, that has been identified when targetting an SLS with trailing dots.

Let say I have the following in my "file_roots":

/srv/salt/
/srv/salt/test/
/srv/salt/test/init.sls

where test/init.sls contains:

Show Variables:
  cmd.run:
    - name: echo "sls = {{sls}}\nslspath = {{slspath}}\nsls_path = {{sls_path}}\ntplfile = {{tplfile}}\ntpldir = {{tpldir}}\ntplpath = {{tplpath}}"

Now, depending how I trigger the state, I got wrong calculation of SLS context variables (slspath, slsdotpath, slscolonpath, sls_path), where the expected relative paths are actually rendered as absolute paths:

# This works as expected
# salt <minion> state.sls test 
...
                  sls = test
                  slspath = test
                  sls_path = test
                  tplfile = test/init.sls
                  tpldir = test
                  tplpath = /var/cache/salt/minion/files/test_edit/test/init.sls
...

# This DOES NOT work as expected
# salt <minion> state.sls test.
...
                  sls = test.
                  slspath = /var/cache/salt/minion/files/test_edit/test
                  sls_path = _var_cache_salt_minion_files_test_edit_test
                  tplfile = /var/cache/salt/minion/files/test_edit/test/init.sls
                  tpldir = /var/cache/salt/minion/files/test_edit/test
                  tplpath = /var/cache/salt/minion/files/test_edit/test/init.sls

# This works as expected
# salt <minion> state.sls test.init
...
                  sls = test.init
                  slspath = test
                  sls_path = test
                  tplfile = test/init.sls
                  tpldir = test
                  tplpath = /var/cache/salt/minion/files/test_edit/test/init.sls
...

Additionally, this PR fixes a bad logic for test comparison that was making related tests to always pass.

What issues does this PR fix or reference?

Fixes: #63411

Previous Behavior

As mentioned, when targetting as test., I got unexpected absolute paths:

                  sls = test.
                  slspath = /var/cache/salt/minion/files/test_edit/test
                  sls_path = _var_cache_salt_minion_files_test_edit_test
                  tplfile = /var/cache/salt/minion/files/test_edit/test/init.sls
                  tpldir = /var/cache/salt/minion/files/test_edit/test
                  tplpath = /var/cache/salt/minion/files/test_edit/test/init.sls

New Behavior

After this PR, I got expected values:

                  sls = test.
                  slspath = test
                  sls_path = test
                  tplfile = test/init.sls
                  tpldir = test
                  tplpath = /var/cache/salt/minion/files/test_edit/test/init.sls

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

• Docs
• Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
• Tests written/updated

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

[s0undt3ch]

Why would someone target a test. sls, and why should salt handle that extra dot?

[meaksh]

Why would someone target a test. sls, and why should salt handle that extra dot?

Yeah, this is a bit strange, I don't think someone would do that on purpose, but this PR just prevents the inconsistent values to appear while it just mimic the behavior of state.apply and other state.* functions when it comes to resolve the state to run:

• test -> test.init
• test. -> test.init
• test.init -> test.init