[master] Fix optimization_order opt to prevent test fails#65266
Merged
dwoz merged 4 commits intosaltstack:masterfrom Jan 30, 2026
Merged
[master] Fix optimization_order opt to prevent test fails#65266dwoz merged 4 commits intosaltstack:masterfrom
dwoz merged 4 commits intosaltstack:masterfrom
Conversation
salt-project-bot-prod-environment
bot
changed the title
vzhestkov
force-pushed
the
fix-tests-with-optimization_order
branch
from
cf34b5f to
c8ac512
Compare
3 tasks
dwoz
requested changes
Dec 18, 2023
Contributor
dwoz
left a comment
dwoz
left a comment
There was a problem hiding this comment.
Rather than this I think we should ad a default value default value of [0,1,2]
in salt.loader.lazy.LazyLoader.__init__ and then remove all these configs from tests.
vzhestkov
force-pushed
the
fix-tests-with-optimization_order
branch
3 times, most recently
from
2b18178 to
3996fe4
Compare
twangboy
approved these changes
May 16, 2025
twangboy
force-pushed
the
fix-tests-with-optimization_order
branch
from
1f73fd2 to
eeaa9ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some tests contains incomplete list of
optimization_orderopt what can cause fails on running these tests when having optimized compiledpycfiles for the modules.Previous Behavior
Possible test fails if there are
pycfiles in place.New Behavior
Normal test runs
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.