[master] Add pruning option to file.keyvalue#65640
Merged
dwoz merged 2 commits intosaltstack:masterfrom Jan 30, 2026
Merged
Conversation
salt-project-bot-prod-environment
bot
changed the title
tacerus
force-pushed
the
keyvalue-prune
branch
2 times, most recently
from
e335fd8 to
79a065b
Compare
twangboy
requested changes
Apr 4, 2025
Contributor
twangboy
left a comment
twangboy
left a comment
There was a problem hiding this comment.
If we get this in it will be part of 3008
twangboy
previously approved these changes
Apr 9, 2025
Contributor
twangboy
left a comment
twangboy
left a comment
There was a problem hiding this comment.
Once the nightly builds are green we'll need to rebase this.
This implements a new optional argument "prune" in the file.keyvalue state function, which, if set to True, deletes lines not configured using the "key_values" or "key"/"value" arguments as part of the execution. Useful for ensuring a file only contains the desired key/value pairs and no additional data. Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
twangboy
force-pushed
the
keyvalue-prune
branch
from
5e169b1 to
c332db7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This implements a new optional argument "prune" in the file.keyvalue state function, which, if set to True, deletes lines not configured using the "key_values" or "key"/"value" arguments as part of the execution. Useful for ensuring a file only contains the desired key/value pairs and no additional data.
What issues does this PR fix or reference?
Fixes: #65631
Previous Behavior
prunewas not a valid argument.New Behavior
pruneis a a valid argument! :-)Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes