[master] Add onlyifrunning option for Service Beacon#66809
Merged
dwoz merged 1 commit intosaltstack:masterfrom Jan 30, 2026
Merged
[master] Add onlyifrunning option for Service Beacon#66809dwoz merged 1 commit intosaltstack:masterfrom
dwoz merged 1 commit intosaltstack:masterfrom
Conversation
d55137e to
fd955f8
Compare
fd955f8 to
38a5731
Compare
Contributor
|
I think the name of this should change.
Perhaps something like |
Contributor
Author
|
Ah, yes. I was a bit lost in naming the parameter. Maybe filter should be added, as it will filter out only the matched state? Something like |
38a5731 to
f31ebe9
Compare
twangboy
approved these changes
Sep 20, 2024
dmurphy18
approved these changes
Sep 20, 2024
With this option it's able to only fire events that match the running state
df9cfbc to
3594838
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this option it's able to only fire events that match the running state
What does this PR do?
I added this change because I don't want my Salt master being overloaded with events I'm not interested in. In my case I only would receive an event when the service is stopped. Without this change the event bus is, for all connected minions, overloaded with events about the running services which I will ignore. This will filter these events from the beacon directly.
What issues does this PR fix or reference?
Previous Behavior
Without this option it will fire the event without filtering the running state
New Behavior
It allows the user to configure that an event should only be fired when the running state is matched with what's configured per service.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.