Add ceph to the specialFSes to match on name for set_fstab#68203
Add ceph to the specialFSes to match on name for set_fstab#68203dwoz merged 1 commit intosaltstack:masterfrom
Conversation
|
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey. There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
twangboy
left a comment
There was a problem hiding this comment.
Please create a changelog (requires an issue) and write a test for this.
1ae3b15 to
4203cf4
Compare
|
I added a unit test and a changelog entry |
4203cf4 to
ec328a3
Compare
Add unit test for set_fstab that covers the case of specialFSes
ec328a3 to
3b90add
Compare
|
Congratulations on your first PR being merged! 🎉 |
What does this PR do?
Add cephfs to the set of FSes that are being matched by name instead of device in set_fstab
What issues does this PR fix or reference?
It's common to have multiple cephfs'es in fstab that share the same device. Currently
match_on: namemust be explicitly set to correctly handle this case.Previous Behavior
match_on: nameis required to be explicitly set when adding multiple cephfs mountpoints that share the same deviceNew Behavior
match_on: autodefault value is sufficientMerge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No
Closes #68207