Open
Conversation
sameerkumar18
requested changes
Oct 2, 2017
Owner
sameerkumar18
left a comment
sameerkumar18
left a comment
There was a problem hiding this comment.
I think it has unnecessary dependencies in requirements.txt
See if you can fix those.
Also is flask_restful being used in your code?
Author
|
Oh you're right! It had added more outside of my virtualenv. How odd. Anyways, I fixed that. I only added the requests module and its dependencies. Yes, flask_restful is still being used, it's being used for the '/api' route. I replaced the '/' route to use Flask instead of flask_restful. Since I noticed you might want to develop a website in the future, setting up the '/' route with Flask is essential, because flask_restful isn't a good tool for delivering webpages and things. |
Author
|
Sorry I'm still kind of new to pull requests and doing all this. So I hope I'm doing this right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made it so it works with Python3. Added test file to test both API and Website. Changed Website portion, to make it easier add webpages and things later on. Changed range_end to always have the correct number without having to manually change everytime.