Draft
Conversation
…t port number if standard.
Member
Author
|
Setting |
Member
Maybe also time to handle the whole server name issue. 😉 |
ahopkins
reviewed
Sep 6, 2023
Comment on lines
+676
to
+696
| # colon(:) is legal for a host only in an ipv6 address | ||
| url_host = f"[{host}]" if ":" in host else host | ||
| url_port = ( | ||
| "" | ||
| if ( | ||
| (proto == "https" and port == 443) | ||
| or (proto == "http" and port == 80) | ||
| ) | ||
| else f":{port}" | ||
| ) | ||
|
|
||
| special = { | ||
| "127.0.0.1": "IPv4", | ||
| "0.0.0.0": "IPv4 wildcard", | ||
| "::1": "IPv6", | ||
| "::": "IPv6 wildcard", | ||
| }.get(host, "") | ||
| if special: | ||
| return f"({special}) {proto}://localhost{url_port}" | ||
|
|
||
| return serve_location | ||
| return f"{proto}://{url_host}{url_port}" |
Member
There was a problem hiding this comment.
This whole bit feels to me like logic we should probably abstract to a utility function somewhere. Don't we do this elsewhere also?
Member
Author
That's a can of worms, for sure. Would be useful to first identify all the problems that we are solving here, and things affected by them.
What'd I miss? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sanic would use any host setting for URL construction. This PR fixes the common cases of normal localhost and wildcard addresses, for which we instead display localhost. Similarly for UNIX sockets, as that format works e.g. with curl. URL to wildcard doesn't work at all, and connecting localhost by IP rather than domain name can be problematic with TLS if not otherwise.
Additionally, hides the port number if standard ports are used.