Skip to content

fix: keep TableMenu dialog input controlled#55

Open
mehmetyildizdev wants to merge 1 commit intosanity-io:mainfrom
mehmetyildizdev:fix/tablemenu-controlled-input
Open

fix: keep TableMenu dialog input controlled#55
mehmetyildizdev wants to merge 1 commit intosanity-io:mainfrom
mehmetyildizdev:fix/tablemenu-controlled-input

Conversation

@mehmetyildizdev
Copy link

Description

  • Ensure the TableMenu dialog TextInput is always controlled by initializing count as an empty string and resetting it when the dialog opens/closes.
  • Silences the React controlled/uncontrolled warning and keeps the dialog input consistent.

What to review

  • Open the Table menu, trigger each “Add …” action, and confirm the dialog input remains editable without console warnings.
  • Double-check the confirm handler still submits the entered value correctly.

Testing

  • Manually tested by opening each dialog, typing values, cancelling, and confirming to verify no warnings and correct behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant