scheduler: Add weighers for same shard (live-)migration#455
Draft
joker-at-work wants to merge 1 commit intooffline-migrate-gets-own-nova-check-typefrom
Draft
scheduler: Add weighers for same shard (live-)migration#455joker-at-work wants to merge 1 commit intooffline-migrate-gets-own-nova-check-typefrom
joker-at-work wants to merge 1 commit intooffline-migrate-gets-own-nova-check-typefrom
Conversation
We want to prefer staying in the same shard on live-migration and on offline migration, because migrating VMs with volumes attached induces overhead. Therefore, we add `PreferSameShardOnLiveMigrateWeigher` and `PreferSameShardOnMigrateWeigher`. Since we already had that functionality available for resizes through `PreferSameShardOnResizeWeigher`, we refactored the weigher into a base class configured by class attribute `_TYPE`. Change-Id: I0d28b675562ec220163b8a159802c2126280c272
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to prefer staying in the same shard on live-migration and on offline migration, because migrating VMs with volumes attached induces overhead. Therefore, we add
PreferSameShardOnLiveMigrateWeigherandPreferSameShardOnMigrateWeigher.Since we already had that functionality available for resizes through
PreferSameShardOnResizeWeigher, we refactored the weigher into a base class configured by class attribute_TYPE.Change-Id: I0d28b675562ec220163b8a159802c2126280c272