Update rules with missing rules from updated pluralize js library#18
Open
Jerome2606 wants to merge 1 commit intosarathkcm:masterfrom
Open
Update rules with missing rules from updated pluralize js library#18Jerome2606 wants to merge 1 commit intosarathkcm:masterfrom
Jerome2606 wants to merge 1 commit intosarathkcm:masterfrom
Conversation
Owner
|
Hi @Jerome2606, Thank you for taking the time to contribute - appreciate it. Could you please provide the commit ID up to which you have synchronized the rules? Asking because I could find some extra rules in the latest master branch of the original library. Thanks & Regards |
Owner
|
I'll just outline what I observed.
Kindly update these if you were going for complete sync with the master branch of the original library. Otherwise no worries, please just update the commit ID up to which your changes reflect in the Readme file, and as long as your changes cover all the changes & the tests up to that commit ID - I'll be happy to merge this PR. Thanks & Regards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made the comparison with the actual master branch on the JS pluralize library to update all the changes (not much at the end)