Add support for booking_rules.txt to gtfs-schedule module#36
Merged
Conversation
🤖 Generated with [GitHub Copilot](https://copilot.github.com) Co-Authored-By: GitHub Copilot <noreply@github.com> Co-authored-by: sargunv <1320357+sargunv@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for booking_rules.txt to gtfs-schedule module
Add support for booking_rules.txt to gtfs-schedule module
Oct 23, 2025
sargunv
requested changes
Oct 23, 2025
Owner
sargunv
left a comment
There was a problem hiding this comment.
@copilot handle my comment, and resolve merge conflicts with main.
Comment on lines
25
to
29
| /** Minimum number of minutes before travel to make the request. */ | ||
| @SerialName("prior_notice_duration_min") public val priorNoticeDurationMin: WholeSeconds? = null, | ||
|
|
||
| /** Maximum number of minutes before travel to make the request. */ | ||
| @SerialName("prior_notice_duration_max") public val priorNoticeDurationMax: WholeSeconds? = null, |
Contributor
Author
There was a problem hiding this comment.
Fixed in bb28fc8. Changed WholeSeconds to WholeMinutes for prior_notice_duration_min and prior_notice_duration_max fields.
Contributor
Author
Merge conflicts resolved in f0916b8. Merged main branch which added Shape, LocationGroup, LocationGroupStop, Transfer, and Frequency models. The TODO list in ProducerTest now includes both booking_rules.txt and frequencies.txt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.