Run sudo if not in docker group

[gportay]

The docker client requires to run as root in rootfull mode. The docker
group allows a user to access to the Unix socket created by the docker
daemon.

The user needs to run docker client with more privileges (i.e. sudo) if
it is not part of that group1.

This prepends sudo to CQFD_DOCKER automatically if CQFD_RUN_WITH_SUDO is
set to true. It turns the internal variable cqfd_docket into an array to
split the command into pieces ("sudo docker" -> "sudo" and "docker").

[gportay]

What your thought on this?

[felixlechat1]

Looks good to me, I think it makes sense to have the feature be a separate environment variable. Maybe just update the CQFD_DOCKER readme section to not suggest using sudo there, rather in the new CQFD_RUN_WITH_SUDO variable.

I like the idea of switching to USER sooner instead of using a builder user. Are there any implications to not have that separate builder user for the first few steps of cqfd? Couldn't find any on my side.

[gportay]

Maybe just update the CQFD_DOCKER readme section to not suggest using sudo there, rather in the new CQFD_RUN_WITH_SUDO variable.

Oh good catch!

In fact, I would like to update to

I like the idea of switching to USER sooner instead of using a builder user. Are there any implications to not have that separate builder user for the first few steps of cqfd? Couldn't find any on my side.

I have seen none.

In fact I would have choose the user cqfd instead of builder :)

[florentsfl]

At first, I would think that it is a good idea if sudo is left explicit so the user always remember that they are using sudo.

But it is indeed more practical if sudo is included in cqfd.

[gportay]

At first, I would think that it is a good idea if sudo is left explicit so the user always remember that they are using sudo.

And now, I am convinced you were right, and I was wrong to automatically default to sudo if user is not a member of the docker group.

But it is indeed more practical if sudo is included in cqfd.

And yes it would be practical but since docker rootless support is almost merged, with podman, it could be annoying to disable sudo for setup that creates an alias for docker (alias docker=podman). Podman does not need to run as sudo, right?

[florentsfl]

podman does not require sudo indeed

[florentsfl]

honestly I liked the cqfd_user_home name, because with cqfd_home it sounds like it is the home of cqfd

With cqfd_user_home it is clear that this represents the home of the user invoking cqfd

What do you think about that ?

[gportay]

honestly I liked the cqfd_user_home name, because with cqfd_home it sounds like it is the home of cqfd

With cqfd_user_home it is clear that this represents the home of the user invoking cqfd

What do you think about that ?

This is why I suggested to remove the cqfd_ prefix as well.

[gportay]

@florentsfl I have removed the rename of the variable from that PR.

But I guess it is better to rename them so they are just a decapitalized version + cqfd_ prefix.

[florentsfl]

but if someone wants to run $CQFD_DOCKER with sudo, they can just put "sudo docker" in the variable $CQFD_DOCKER ?

[gportay]

but if someone wants to run $CQFD_DOCKER with sudo, they can just put "sudo docker" in the variable $CQFD_DOCKER ?

Yes they can. It is not automatic. No. it needs some changes.

[gportay]

This is just a rebase on top of master.

However, I figured out that cqfd does not work correctly if user is not a member of the docker group.

The command docker run hangs during some tests (not all), it does not even enter the launcher script.