Skip to content

Asynchronous SET NAMES utf8mb4 #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rumblefrog merged 1 commit into from
Nov 2, 2025
Merged

Asynchronous SET NAMES utf8mb4 #1052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions game/addons/sourcemod/scripting/sbpp_comms.sp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1380,9 +1380,15 @@ public void GotDatabase(Database db, const char[] error, any data)
}

// Set character set to UTF8MB4 in the database
char query[128];
Format(query, sizeof(query), "SET NAMES utf8mb4");
db.Query(Query_ErrorCheck, query);
// Use SQL_SetCharset to ensure charset is set synchronously before any operations
if (!db.SetCharset("utf8mb4"))
{
LogError("Failed to set database charset to utf8mb4");
// Fallback to async method
char query[128];
Format(query, sizeof(query), "SET NAMES utf8mb4");
db.Query(Query_ErrorCheck, query);
}

// Process queue
SQLiteDB.Query(Query_ProcessQueue,
Expand Down
11 changes: 9 additions & 2 deletions game/addons/sourcemod/scripting/sbpp_main.sp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1090,8 +1090,15 @@ public void GotDatabase(Database db, const char[] error, any data)

char query[1024];

Format(query, sizeof(query), "SET NAMES utf8mb4");
DB.Query(ErrorCheckCallback, query);
// Set character set to UTF8MB4 in the database
// Use SetCharset to ensure charset is set synchronously before any operations
if (!DB.SetCharset("utf8mb4"))
{
LogToFile(logFile, "Failed to set database charset to utf8mb4, trying async method");
// Fallback to async method
Format(query, sizeof(query), "SET NAMES utf8mb4");
DB.Query(ErrorCheckCallback, query);
}

InsertServerInfo();

Expand Down