chore: Unignore tests that were ignored for JDK 11#2093
Draft
tgodzik wants to merge 1 commit intoscalacenter:mainfrom
Draft
chore: Unignore tests that were ignored for JDK 11#2093tgodzik wants to merge 1 commit intoscalacenter:mainfrom
tgodzik wants to merge 1 commit intoscalacenter:mainfrom
Conversation
Since we only run on JDK 11 currently, those tests wouldn't run ever. I only left the Scala JS tests ignored since there were some issues around that and we need to rework Scala JS integration at some point anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we only run on JDK 11 currently, those tests wouldn't run ever.
I only left the Scala JS tests ignored since there were some issues around that and we need to rework Scala JS integration at some point anyway.