Switch PluginFrontend to domain sockets on macOS#380
Open
bell-db wants to merge 1 commit intoscalapb:masterfrom
Open
Switch PluginFrontend to domain sockets on macOS#380bell-db wants to merge 1 commit intoscalapb:masterfrom
bell-db wants to merge 1 commit intoscalapb:masterfrom
Conversation
mbland
added a commit
to mbland/rules_scala
that referenced
this pull request
Oct 1, 2024
Added a couple more repo dependencies to targets under //test. However, `bazel test //test:all` is a bust for now, because the protoc-bridge mechanism hangs on macOS: - scalapb/protoc-bridge#366 - scalapb/protoc-bridge#367 - scalapb/protoc-bridge#379 - scalapb/protoc-bridge#380 Though scalapb/protoc-bridge#366 suggests that it only hangs occasionally, it's hanging 100% of the time for me on macOS 15.0 on a M3 Max.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Fixes #379 by switching from TCP sockets to Unix domain sockets with server-side read timeout on macOS.
It turns out extremely difficult to find a reliable way to IPC on macOS, when the client is a simple bash script without accessing to mature frameworks. None of the above survived a stress test of 100k runs of 100KB messages:
However, when trying to implement a retry-on-timeout, it's found that, mysteriously, domain sockets with
junixsocketserver are working well with a server-side read timeout alone, even if we don't catch and retry (i.e. there is no timeout exception thrown or hang anymore). It's also the most performant solution on macOS:[1]
macOS: macOS 14.6.1, M2 Max
Linux: Ubuntu 20.04.6 LTS, Xeon(R) Platinum 8375C
How is this tested?
Passes the stress test in #382, after adding
client.setSoTimeout(60000).