Deploy a SASL_PLAIN Kafka listener & test notifications against it#2300
Deploy a SASL_PLAIN Kafka listener & test notifications against it#2300delthas wants to merge 3 commits intodevelopment/2.13from
Conversation
Hello delthas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
There was a problem hiding this comment.
Pull request overview
This PR adds support for testing SASL_PLAIN authenticated Kafka listeners with bucket notifications. It configures a new Kafka listener with SASL authentication and creates the necessary test infrastructure to verify notifications work with authenticated Kafka endpoints.
- Adds a third notification destination with SASL_PLAIN authentication support
- Configures a new Kafka listener on port 9095 with SASL authentication
- Extends test parameters and environment variables to support authenticated notifications
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/ctst/world/Zenko.ts | Adds interface properties for authenticated notification destination configuration |
| tests/ctst/steps/notifications.ts | Implements test step for setting up an authenticated notification destination |
| .github/workflows/end2end.yaml | Defines environment variables for authenticated destination credentials and topic |
| .github/scripts/end2end/run-e2e-ctst.sh | Passes authenticated notification parameters to test world configuration |
| .github/scripts/end2end/configure-e2e.sh | Adds Kafka topic creation for authenticated notification destination |
| .github/scripts/end2end/configure-e2e-ctst.sh | Configures SASL_PLAIN Kafka listener and creates authenticated notification topic |
| .github/scripts/end2end/configs/notification_destinations.yaml | Defines ZenkoNotificationTarget with basic authentication credentials |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
47079c0 to
84be537
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
8c5d50f to
de82fb9
Compare
f2cb766 to
a091dc4
Compare
|
Test failure appears to be unrelated: https://github.com/scality/Zenko/actions/runs/20574693679/job/59089167866#step:10:57882 |
|
Finally passed after 3 retries. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
f1789f5 to
3d0d560
Compare
SylvainSenechal
left a comment
There was a problem hiding this comment.
Might be worth to see what happens with the same test that you added, but unauthenticated.
given a non-authenticated notification
then i should not receive a notifciation
but maybe annoying to setup and not worth it, whatever
|
PR has conflicts ( |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4e9d961 to
0a596e3
Compare
Issue: ZENKO-5106 Signed-off-by: Thomas Flament <thomas.flament@scality.com>
Issue: ZENKO-5106 Signed-off-by: Thomas Flament <thomas.flament@scality.com>
Issue: ZENKO-5106 Signed-off-by: Thomas Flament <thomas.flament@scality.com>
0a596e3 to
bc1f55d
Compare
Issue: ZENKO-5106