sdk v3 migration : follow up on a few details

[SylvainSenechal]

ISSUE: BB-730

[bert-e]

Hello sylvainsenechal,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue BB-730 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 9.2.0

Please check the Fix Version/s of BB-730, or the target
branch of this pull request.

[SylvainSenechal]

https://scality.atlassian.net/browse/VAULT-238
Get caller identity is available in vault

[francoisferrand]

is it available in both Vault 1 and Vault 2 ?

[SylvainSenechal]

Implemented in vault 2 here https://scality.atlassian.net/browse/VAULT-291

[SylvainSenechal]

and here for vault 1 https://scality.atlassian.net/browse/VAULT-214

[codecov]

Codecov Report

❌ Patch coverage is 82.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.25%. Comparing base (79f4b49) to head (21b9081).

Files with missing lines	Patch %	Lines
lib/BackbeatMetadataProxy.js	16.66%	5 Missing ⚠️
...xtensions/replication/tasks/MultipleBackendTask.js	71.42%	2 Missing ⚠️
lib/tasks/BackbeatTask.js	60.00%	2 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
extensions/gc/tasks/GarbageCollectorTask.js	87.28% <100.00%> (ø)
.../lifecycle/tasks/LifecycleColdStatusArchiveTask.js	89.79% <100.00%> (ø)
...sions/lifecycle/tasks/LifecycleDeleteObjectTask.js	92.76% <100.00%> (-0.10%)	⬇️
extensions/lifecycle/tasks/LifecycleTask.js	91.54% <100.00%> (ø)
...nsions/notification/NotificationConfigValidator.js	100.00% <ø> (ø)
extensions/notification/index.js	75.00% <100.00%> (ø)
extensions/replication/tasks/CopyLocationTask.js	67.02% <100.00%> (ø)
extensions/replication/tasks/ReplicateObject.js	91.34% <100.00%> (ø)
extensions/utils/VaultClientWrapper.js	71.18% <ø> (ø)
lib/clients/ClientManager.js	66.66% <100.00%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

Components	Coverage Δ
Bucket Notification	80.22% <100.00%> (ø)
Core Library	80.43% <56.25%> (-0.08%)	⬇️
Ingestion	70.61% <100.00%> (ø)
Lifecycle	78.62% <100.00%> (-0.02%)	⬇️
Oplog Populator	85.06% <ø> (ø)
Replication	59.55% <89.47%> (-0.02%)	⬇️
Bucket Scanner	85.76% <ø> (ø)

@@                 Coverage Diff                 @@
##           development/9.2    #2703      +/-   ##
===================================================
- Coverage            74.28%   74.25%   -0.04%     
===================================================
  Files                  200      200              
  Lines                13565    13562       -3     
===================================================
- Hits                 10077    10070       -7     
- Misses                3478     3482       +4     
  Partials                10       10              

Flag	Coverage Δ
api:retry	9.11% <4.00%> (+<0.01%)	⬆️
api:routes	8.93% <2.00%> (+<0.01%)	⬆️
bucket-scanner	85.76% <ø> (ø)
ft_test:queuepopulator	9.03% <2.00%> (+<0.01%)	⬆️
ingestion	12.48% <8.00%> (-0.04%)	⬇️
lib	7.58% <2.00%> (-0.01%)	⬇️
lifecycle	18.84% <26.00%> (-0.03%)	⬇️
notification	1.03% <0.00%> (+<0.01%)	⬆️
replication	18.41% <46.00%> (-0.03%)	⬇️
unit	50.90% <44.00%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[SylvainSenechal]

ci not passing but you can review, i think it's a small thing because of the test mock returning err.name or something like that

[benzekrimaha]

LGTM