[WIP] Tighten file-api dataclasses#1012
Draft
LecrisUT wants to merge 5 commits intoscikit-build:mainfrom
Draft
Conversation
LecrisUT
force-pushed
the
file-api
branch
2 times, most recently
from
e166471 to
6dade5e
Compare
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Collaborator
Author
|
I guess this is ready for review. I tried to consider versioned dataclasses, but the lack of |
henryiii
reviewed
Mar 11, 2025
LecrisUT
changed the title
henryiii
pushed a commit
that referenced
this pull request
Mar 28, 2025
Cherry-picked from #1012 Signed-off-by: Cristian Le <git@lecris.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one also tries to load the
Directoryobject, but it looses the original data from the CodeModel's field. Ideally this should be revisited so that it can inherit the fields if available.My thought is to have them subclassed and pass along all the parent fields. Or more robustly, we should split them into the individual versioned objects, wdyt?For debugging purposes I've made the file-api failure an error, but should we make that permanent in the future?