add pyplot savefig()#25
Open
holmbuar wants to merge 1 commit intoscikit-tda:masterfrom
holmbuar:savefig
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
- Coverage 80.03% 79.73% -0.31%
==========================================
Files 10 10
Lines 531 533 +2
Branches 105 106 +1
==========================================
Hits 425 425
- Misses 78 79 +1
- Partials 28 29 +1
Continue to review full report at Codecov.
|
sauln
requested changes
Nov 26, 2019
Member
sauln
left a comment
sauln
left a comment
There was a problem hiding this comment.
Sorry it took me so long to circle back about this. Address the couple of comments regarding the arguments and I'll merge asap.
| plt.show() | ||
|
|
||
| if save is True: | ||
| plt.savefig(figures_directory + filename) |
Member
There was a problem hiding this comment.
Could you change it to only accept one argument, filename please.
| ax=None, | ||
| save=False, | ||
| figures_directory=None, | ||
| filename=None |
Member
There was a problem hiding this comment.
Do you need both save and filename? How about if filename is not None, then save to the filename
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using Ripser.py alongside a Docker container running all the python stuff. This makes plotting tricky if at all possible. The workaround is simply to use pyplot.savefig() and save the plots as files.
This pull request is a naive and humble attempt to enable figure saving functionality to Ripser.py. Suggestions, edits and/ or corrections are welcome.