ENH implement local fit for trend curve#234
Draft
BorisMuzellec wants to merge 16 commits intomainfrom
Draft
Conversation
for more information, see https://pre-commit.ci
… parametric trend curve in default inference model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue or PRs
Fixes #231
What does your PR implement? Be specific.
Implement a "local" option for the trend curve using scikit-misc's loess implementation.
A few issues to work on:
scikit-misc
loessobjects are unpicklable. As a result, using a"local"curve fit makes theDeseqDataSetobject unpicklable.On some platforms (Ubuntu in particular),
loesswill cause a segmentation fault, which is not possible to catch using pythontry ... except .... As a workaround,loessis run in a separate process, to avoid the main process crashing in case of a segfault. This is a bit cumbersome, because the child process cannot communicate the fittedloessobject to the main, as it is unpicklable. The current solution is toloessin the main process